Changeset 117752 in webkit

Timestamp:

May 21, 2012, 2:43:48 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] PlatformKeyboardEventEfl is missing ESC key handling.
​https://bugs.webkit.org/show_bug.cgi?id=86837

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-21
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Added ESC key handling.

• platform/efl/EflKeyboardUtilities.cpp:

(WebCore::createKeyMap):
(WebCore::singleCharacterString):

Tools:

• DumpRenderTree/efl/EventSender.cpp:

(keyNameFromJSValue): Added ESC key handling.

LayoutTests:

• platform/efl/Skipped: Unskipped fast/forms/input-search-press-escape-key.html.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/efl/EflKeyboardUtilities.cpp (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/efl/EventSender.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
+        https://bugs.webkit.org/show_bug.cgi?id=86837
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        * platform/efl/Skipped: Unskipped fast/forms/input-search-press-escape-key.html.
+
 2012-05-18  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -676 +676 @@
 fast/events/key-events-in-input-text.html
 fast/events/option-tab.html
-fast/forms/input-search-press-escape-key.html
 
 # BUG: not scrolling correctly

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
+        https://bugs.webkit.org/show_bug.cgi?id=86837
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Added ESC key handling.
+
+        * platform/efl/EflKeyboardUtilities.cpp:
+        (WebCore::createKeyMap):
+        (WebCore::singleCharacterString):
+
 2012-05-21  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp

@@ -85 +85 @@
     keyMap().set("BackSpace", "U+0008");
     keyMap().set("space", "U+0020");
+    keyMap().set("Escape", "U+001B");
     keyMap().set("Print", "PrintScreen");
     // Keypad location
@@ -224 +225 @@
     if (keyName == "Print")
         return String("");
+    if (keyName == "Escape")
+        return String("\x1b");
+
     return keyName;
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2012-05-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
+        https://bugs.webkit.org/show_bug.cgi?id=86837
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        * DumpRenderTree/efl/EventSender.cpp:
+        (keyNameFromJSValue): Added ESC key handling.
+
 2012-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/DumpRenderTree/efl/EventSender.cpp

@@ -449 +449 @@
     if (charCode == ' ')
         return new KeyEventInfo("space", " ", modifiers);
+    if (charCode == '\x1B')
+        return new KeyEventInfo("Escape", "Escape", modifiers);
 
     return new KeyEventInfo(character->ustring().utf8(), character->ustring().utf8(), modifiers);