Changeset 117775 in webkit

Timestamp:

May 21, 2012, 6:18:42 AM (14 years ago)

Author:

apavlov@chromium.org

Message:

Merge 116305 - Web Inspector: [TextPrompt] Event listeners and CSS style are not removed on detachment
​https://bugs.webkit.org/show_bug.cgi?id=85789

Reviewed by Yury Semikhatsky.

• inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):

TBR=​apavlov@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10408041

File:

• branches/chromium/1132/Source/WebCore/inspector/front-end/TextPrompt.js (modified) (2 diffs)

branches/chromium/1132/Source/WebCore/inspector/front-end/TextPrompt.js

@@ -113 +113 @@
         this._element.addStyleClass("text-prompt");
         this._element.addEventListener("keydown", this._boundOnKeyDown, false);
-        this._element.addEventListener("selectstart", this._selectStart.bind(this), false);
+        this._element.addEventListener("selectstart", this._boundSelectStart, false);
 
         if (typeof this._suggestBoxClassName === "string")
@@ -126 +126 @@
         this.proxyElement.parentElement.insertBefore(this._element, this.proxyElement);
         this.proxyElement.parentElement.removeChild(this.proxyElement);
+        this._element.removeStyleClass("text-prompt");
+        this._element.removeEventListener("keydown", this._boundOnKeyDown, false);
+        this._element.removeEventListener("selectstart", this._boundSelectStart, false);
         delete this._proxyElement;
         WebInspector.restoreFocusFromElement(this._element);