Changeset 117785 in webkit

Timestamp:

May 21, 2012, 8:54:58 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Clients should be able to set page cache capacity.
​https://bugs.webkit.org/show_bug.cgi?id=86960

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-05-21
Reviewed by Csaba Osztrogonác.

Exported memory page cache capacity getter and setter functions.
Those will be used both by clients and DRT Layout Test Controller.

• ewk/ewk_settings.cpp:

(ewk_settings_page_cache_capacity_get):
(ewk_settings_page_cache_capacity_set):

• ewk/ewk_settings.h:

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_main.cpp (modified) (1 diff)
• ewk/ewk_settings.cpp (modified) (1 diff)
• ewk/ewk_settings.h (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2012-05-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL] Clients should be able to set page cache capacity.
+        https://bugs.webkit.org/show_bug.cgi?id=86960
+
+        Reviewed by Csaba Osztrogonác.
+
+        Exported memory page cache capacity getter and setter functions.
+        Those will be used both by clients and DRT Layout Test Controller.
+
+        * ewk/ewk_settings.cpp:
+        (ewk_settings_page_cache_capacity_get):
+        (ewk_settings_page_cache_capacity_set):
+        * ewk/ewk_settings.h:
+
 2012-05-21  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 

trunk/Source/WebKit/efl/ewk/ewk_main.cpp

@@ -151 +151 @@
     // Page cache capacity (in pages). Comment from Mac port:
     // (Research indicates that value / page drops substantially after 3 pages.)
-    // FIXME: Expose this with an API and/or calculate based on available resources
-    WebCore::pageCache()->setCapacity(3);
+    // FIXME: Calculate based on available resources
+    ewk_settings_page_cache_capacity_set(3);
     WebCore::PageGroup::setShouldTrackVisitedLinks(true);
 

trunk/Source/WebKit/efl/ewk/ewk_settings.cpp

@@ -249 +249 @@
 }
 
+unsigned ewk_settings_page_cache_capacity_get()
+{
+    return WebCore::pageCache()->capacity();
+}
+
+void ewk_settings_page_cache_capacity_set(unsigned pages)
+{
+    WebCore::pageCache()->setCapacity(pages);
+}
+
 void ewk_settings_memory_cache_clear()
 {

trunk/Source/WebKit/efl/ewk/ewk_settings.h

@@ -295 +295 @@
  */
 EAPI void             ewk_settings_object_cache_capacity_set(unsigned min_dead_bytes, unsigned max_dead_bytes, unsigned total_bytes);
+
+/**
+ * Returns the maximum number of pages in the memory page cache.
+ *
+ * By default, maximum number of pages is 3.
+ *
+ * @return  The maximum number of pages in the memory page cache.
+ *
+ * @sa ewk_settings_page_cache_capacity_set
+ */
+EAPI unsigned         ewk_settings_page_cache_capacity_get(void);
+
+/**
+ * Defines the capacity for the memory page cache.
+ *
+ * The page cache is responsible for holding visited web pages in memory. So it improves user experience when navigating forth or back
+ * to pages in the forward/back history as the cached pages do not require to be loaded from server.
+ *
+ * By default, @p pages is 3.
+ *
+ * @param pages The maximum number of pages to keep in the memory page cache.
+ */
+EAPI void             ewk_settings_page_cache_capacity_set(unsigned pages);
 
 /**