⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 117803 in webkit


Ignore:
Timestamp:
May 21, 2012, 11:42:59 AM (14 years ago)
Author:
dmazzoni@google.com
Message:

AX: A disabled select element should not be exposed as focusable
​https://bugs.webkit.org/show_bug.cgi?id=86949

Reviewed by Chris Fleizach.

  • LayoutTests/accessibility/disabled-controls-not-focusable-expected.txt: Added.
  • LayoutTests/accessibility/disabled-controls-not-focusable.html: Added.
  • Source/WebCore/accessibility/AccessibilityListBox.h:

(AccessibilityListBox):

  • Source/WebCore/accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::canSetFocusAttribute):
(WebCore):

  • Source/WebCore/accessibility/AccessibilityMenuList.h:

(AccessibilityMenuList):

Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r117722 r117803  
     12012-05-21  Dominic Mazzoni  <dmazzoni@google.com>
     2
     3        AX: A disabled select element should not be exposed as focusable
     4        https://bugs.webkit.org/show_bug.cgi?id=86949
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * LayoutTests/accessibility/disabled-controls-not-focusable-expected.txt: Added.
     9        * LayoutTests/accessibility/disabled-controls-not-focusable.html: Added.
     10        * Source/WebCore/accessibility/AccessibilityListBox.h:
     11        (AccessibilityListBox):
     12        * Source/WebCore/accessibility/AccessibilityMenuList.cpp:
     13        (WebCore::AccessibilityMenuList::canSetFocusAttribute):
     14        (WebCore):
     15        * Source/WebCore/accessibility/AccessibilityMenuList.h:
     16        (AccessibilityMenuList):
     17
    1182012-05-20  George Staikos  <staikos@webkit.org>
    219

  • trunk/Source/WebCore/accessibility/AccessibilityListBox.h

    r111699 r117803  
    4444    virtual bool isListBox() const { return true; }
    4545   
    46     virtual bool canSetFocusAttribute() const { return true; }
    4746    virtual bool canSetSelectedChildrenAttribute() const;
    4847    void setSelectedChildren(AccessibilityChildrenVector&);

  • trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp

    r97177 r117803  
    8383}
    8484
     85bool AccessibilityMenuList::canSetFocusAttribute() const
     86{
     87    if (!node())
     88        return false;
     89
     90    return static_cast<Element*>(node())->isEnabledFormControl();
     91}
     92
    8593void AccessibilityMenuList::didUpdateActiveOption(int optionIndex)
    8694{

  • trunk/Source/WebCore/accessibility/AccessibilityMenuList.h

    r96966 r117803  
    5151    virtual AccessibilityRole roleValue() const { return PopUpButtonRole; }
    5252    virtual bool accessibilityIsIgnored() const { return false; }
    53     virtual bool canSetFocusAttribute() const { return true; }
     53    virtual bool canSetFocusAttribute() const;
    5454
    5555    virtual void addChildren();
Note: See TracChangeset for help on using the changeset viewer.