Changeset 118606 in webkit

Timestamp:

May 25, 2012, 11:39:29 PM (14 years ago)

Author:

nduca@chromium.org

Message:

[chromium] Instrument V8 GC with TraceEvent
​https://bugs.webkit.org/show_bug.cgi?id=87530

Reviewed by Kentaro Hara.

We sometimes get performance issues where performance stalls can
be attributed to badly timed GC operations, especially ones that
happen just before a frame running. This adds tracing calls around
GC so that we can better understand these kinds of hangs.

• bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::gcEpilogue):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8GCController.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-25  Nat Duca  <nduca@chromium.org>
+
+        [chromium] Instrument V8 GC with TraceEvent
+        https://bugs.webkit.org/show_bug.cgi?id=87530
+
+        Reviewed by Kentaro Hara.
+
+        We sometimes get performance issues where performance stalls can
+        be attributed to badly timed GC operations, especially ones that
+        happen just before a frame running. This adds tracing calls around
+        GC so that we can better understand these kinds of hangs.
+
+        * bindings/v8/V8GCController.cpp:
+        (WebCore::V8GCController::gcPrologue):
+        (WebCore::V8GCController::gcEpilogue):
+
 2012-05-25  Garrett Casto  <gcasto@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8GCController.cpp

@@ -60 +60 @@
 #include <wtf/UnusedParam.h>
 
+#if PLATFORM(CHROMIUM)
+#include "TraceEvent.h"
+#endif
+
 namespace WebCore {
 
@@ -390 +394 @@
     v8::HandleScope scope;
 
+#if PLATFORM(CHROMIUM)
+    TRACE_EVENT_BEGIN0("v8", "GC");
+#endif
+
 #ifndef NDEBUG
     DOMObjectVisitor domObjectVisitor;
@@ -510 +518 @@
     enumerateGlobalHandles();
 #endif
+
+#if PLATFORM(CHROMIUM)
+    TRACE_EVENT_END0("v8", "GC");
+#endif
 }