Changeset 118612 in webkit

Timestamp:

May 26, 2012, 1:15:56 PM (14 years ago)

Author:

Simon Fraser

Message:

Clip rects assertion when hovering div with transform
​https://bugs.webkit.org/show_bug.cgi?id=87580

Source/WebCore:

Reviewed by Eric Seidel.

Hit testing used to use temporary clip rects in composited documents,
until r118562. Now that we cache clip rects for hit testing, we need
to clear the cache on descendant layers when a layer gains or loses
a transform.

Test: fast/layers/clip-rects-assertion.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateTransform):

LayoutTests:

Reviewed by Eric Seidel.

Test that changes transform on hover style, testing for clipRect-related
assertions.

• fast/layers/clip-rects-assertion-expected.txt: Added.
• fast/layers/clip-rects-assertion.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/layers/clip-rects-assertion-expected.txt (added)
• LayoutTests/fast/layers/clip-rects-assertion.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-26  Simon Fraser  <simon.fraser@apple.com>
+
+        Clip rects assertion when hovering div with transform
+        https://bugs.webkit.org/show_bug.cgi?id=87580
+
+        Reviewed by Eric Seidel.
+        
+        Test that changes transform on hover style, testing for clipRect-related
+        assertions.
+
+        * fast/layers/clip-rects-assertion-expected.txt: Added.
+        * fast/layers/clip-rects-assertion.html: Added.
+
 2012-05-26  Rob Buis  <rwlbuis@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-26  Simon Fraser  <simon.fraser@apple.com>
+
+        Clip rects assertion when hovering div with transform
+        https://bugs.webkit.org/show_bug.cgi?id=87580
+
+        Reviewed by Eric Seidel.
+        
+        Hit testing used to use temporary clip rects in composited documents,
+        until r118562. Now that we cache clip rects for hit testing, we need
+        to clear the cache on descendant layers when a layer gains or loses
+        a transform.
+
+        Test: fast/layers/clip-rects-assertion.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::updateTransform):
+
 2012-05-25  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -509 +509 @@
         else
             m_transform.clear();
+        
+        // Layers with transforms act as clip rects roots, so clear the cached clip rects here.
+        clearClipRectsIncludingDescendants();
     }