Changeset 118615 in webkit

Timestamp:

May 26, 2012, 3:08:43 PM (14 years ago)

Author:

mjs@apple.com

Message:

REGRESSION (r116720): Subframe PDF scrolls extremely slowly
​https://bugs.webkit.org/show_bug.cgi?id=87557
<rdar://problem/11499408>

Reviewed by Anders Carlsson.

It's not possible to make an automated test for this.

• WebProcess/Plugins/PDF/BuiltInPDFView.mm:

(WebKit::BuiltInPDFView::wantsWheelEvents): Return true instead of false and delete
misleading comment. While the built-in PDF view would get added to the set of scrollable
areas anyway, there are some code paths that check wantsWheelEvents explicitly, so it seems
necessary to reutrn true.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Plugins/PDF/BuiltInPDFView.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-05-25  Maciej Stachowiak  <mjs@apple.com>
+
+        REGRESSION (r116720): Subframe PDF scrolls extremely slowly
+        https://bugs.webkit.org/show_bug.cgi?id=87557
+        <rdar://problem/11499408>
+
+        Reviewed by Anders Carlsson.
+        
+        It's not possible to make an automated test for this.
+
+        * WebProcess/Plugins/PDF/BuiltInPDFView.mm:
+        (WebKit::BuiltInPDFView::wantsWheelEvents): Return true instead of false and delete
+        misleading comment. While the built-in PDF view would get added to the set of scrollable
+        areas anyway, there are some code paths that check wantsWheelEvents explicitly, so it seems
+        necessary to reutrn true.
+
 2012-05-25  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm

@@ -474 +474 @@
 bool BuiltInPDFView::wantsWheelEvents()
 {
-    // We return false here even though we do want wheel events, because we add ourselves to the scrollable area set in updateScrollbars().
-    return false;
+    return true;
 }