Changeset 118622 in webkit

Timestamp:

May 27, 2012, 12:34:01 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[FileAPI] FileReader should fire progress event when blob has been completely read into memory
​https://bugs.webkit.org/show_bug.cgi?id=87585

Patch by Li Yin <​li.yin@intel.com> on 2012-05-27
Reviewed by Kentaro Hara.

From Spec: ​http://www.w3.org/TR/FileAPI/#dfn-progress-event
One progress event will fire when blob has been completely read into memory.
Firefox, Opera and IE follows the spec.
Webkit based browser doesn't do that, it only fires progress event at interval of 50ms.
WebKit should add the behavior to make the conformance with the spec.

Source/WebCore:

Tests: fast/files/file-reader-event-listener.html

• fileapi/FileReader.cpp:

(WebCore::FileReader::didFinishLoading):

LayoutTests:

• fast/files/file-reader-event-listener-expected.txt:
• fast/files/file-reader-event-listener.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/files/file-reader-event-listener-expected.txt (modified) (1 diff)
• LayoutTests/fast/files/file-reader-event-listener.html (modified) (3 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/fileapi/FileReader.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-27  Li Yin  <li.yin@intel.com>
+
+        [FileAPI] FileReader should fire progress event when blob has been completely read into memory
+        https://bugs.webkit.org/show_bug.cgi?id=87585
+
+        Reviewed by Kentaro Hara.
+
+        From Spec: http://www.w3.org/TR/FileAPI/#dfn-progress-event
+        One progress event will fire when blob has been completely read into memory.
+        Firefox, Opera and IE follows the spec.
+        Webkit based browser doesn't do that, it only fires progress event at interval of 50ms.
+        WebKit should add the behavior to make the conformance with the spec.
+
+        * fast/files/file-reader-event-listener-expected.txt:
+        * fast/files/file-reader-event-listener.html:
+
 2012-05-26  Li Yin  <li.yin@intel.com>
 

trunk/LayoutTests/fast/files/file-reader-event-listener-expected.txt

@@ -3 +3 @@
 Received loadstart event
 Received foo event
+Received progress event
 Received load event
 Received loadend event

trunk/LayoutTests/fast/files/file-reader-event-listener.html

@@ -7 +7 @@
 <script>
 var fileReader;
+var receivedProgressEvent = false;
 
 function log(message)
@@ -24 +25 @@
 }
 
+function onProgress()
+{
+    receivedProgressEvent = true;
+}
+
 function onLoad()
 {
+    if (receivedProgressEvent)
+        log("Received progress event");
     log("Received load event");
 }
@@ -65 +73 @@
     fileReader.readAsText(file);
     fileReader.addEventListener("loadstart", onLoadStart, false);
+    fileReader.addEventListener("progress", onProgress, false);
     fileReader.addEventListener("load", onLoad, false);
     fileReader.addEventListener("loadend", onLoadEnd, false);

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-27  Li Yin  <li.yin@intel.com>
+
+        [FileAPI] FileReader should fire progress event when blob has been completely read into memory
+        https://bugs.webkit.org/show_bug.cgi?id=87585
+
+        Reviewed by Kentaro Hara.
+
+        From Spec: http://www.w3.org/TR/FileAPI/#dfn-progress-event
+        One progress event will fire when blob has been completely read into memory.
+        Firefox, Opera and IE follows the spec.
+        Webkit based browser doesn't do that, it only fires progress event at interval of 50ms.
+        WebKit should add the behavior to make the conformance with the spec.
+
+        Tests: fast/files/file-reader-event-listener.html
+
+        * fileapi/FileReader.cpp:
+        (WebCore::FileReader::didFinishLoading):
+
 2012-05-26  Li Yin  <li.yin@intel.com>
 

trunk/Source/WebCore/fileapi/FileReader.cpp

@@ -219 +219 @@
     m_state = DONE;
 
+    fireEvent(eventNames().progressEvent);
     fireEvent(eventNames().loadEvent);
     fireEvent(eventNames().loadendEvent);