Changeset 118648 in webkit

Timestamp:

May 27, 2012, 10:13:48 PM (14 years ago)

Author:

shinyak@chromium.org

Message:

cut, copy or paste event won't be fired in Shadow DOM.
​https://bugs.webkit.org/show_bug.cgi?id=87352

Reviewed by Dimitri Glazkov.

Source/WebCore:

cut, copy or paste event was not fired in Shadow DOM.
Since event re-targeting has been implemented, it should be safe to fire them in Shadow DOM now.

Tests: fast/dom/shadow/cppevent-in-shadow.html

fast/dom/shadow/cppevent-input-in-shadow.html

• editing/Editor.cpp:

(WebCore::Editor::findEventTargetFrom):

LayoutTests:

• fast/dom/shadow/cppevent-in-shadow-expected.txt: Added.
• fast/dom/shadow/cppevent-in-shadow.html: Added.
• fast/dom/shadow/cppevent-input-in-shadow-expected.txt: Added.
• fast/dom/shadow/cppevent-input-in-shadow.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/shadow/cppevent-in-shadow-expected.txt (added)
• LayoutTests/fast/dom/shadow/cppevent-in-shadow.html (added)
• LayoutTests/fast/dom/shadow/cppevent-input-in-shadow-expected.txt (added)
• LayoutTests/fast/dom/shadow/cppevent-input-in-shadow.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/Editor.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-05-27  Shinya Kawanaka  <shinyak@chromium.org>
+
+        cut, copy or paste event won't be fired in Shadow DOM.
+        https://bugs.webkit.org/show_bug.cgi?id=87352
+
+        Reviewed by Dimitri Glazkov.
+
+        * fast/dom/shadow/cppevent-in-shadow-expected.txt: Added.
+        * fast/dom/shadow/cppevent-in-shadow.html: Added.
+        * fast/dom/shadow/cppevent-input-in-shadow-expected.txt: Added.
+        * fast/dom/shadow/cppevent-input-in-shadow.html: Added.
+
 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-27  Shinya Kawanaka  <shinyak@chromium.org>
+
+        cut, copy or paste event won't be fired in Shadow DOM.
+        https://bugs.webkit.org/show_bug.cgi?id=87352
+
+        Reviewed by Dimitri Glazkov.
+
+        cut, copy or paste event was not fired in Shadow DOM.
+        Since event re-targeting has been implemented, it should be safe to fire them in Shadow DOM now.
+
+        Tests: fast/dom/shadow/cppevent-in-shadow.html
+               fast/dom/shadow/cppevent-input-in-shadow.html
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::findEventTargetFrom):
+
 2012-05-27  Hayato Ito  <hayato@chromium.org>
 

trunk/Source/WebCore/editing/Editor.cpp

@@ -675 +675 @@
     if (!target)
         return 0;
-    return target->shadowAncestorNode();
-
+
+    return target;
 }