Changeset 118649 in webkit

Timestamp:

May 27, 2012, 10:48:45 PM (14 years ago)

Author:

Darin Adler

Message:

Fix an incorrect assertion in Vector::remove
​https://bugs.webkit.org/show_bug.cgi?id=87612

Reviewed by Dan Bernstein.

• wtf/Vector.h: There's no good reason to disallow calling remove

with a size of 0, even when the position is at the end of the vector,
so changed the two-argument Vector::remove assertion to assert that
the position is <= size rather than < size.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Vector.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2012-05-27  Darin Adler  <darin@apple.com>
+
+        Fix an incorrect assertion in Vector::remove
+        https://bugs.webkit.org/show_bug.cgi?id=87612
+
+        Reviewed by Dan Bernstein.
+
+        * wtf/Vector.h: There's no good reason to disallow calling remove
+        with a size of 0, even when the position is at the end of the vector,
+        so changed the two-argument Vector::remove assertion to assert that
+        the position is <= size rather than < size.
+
 2012-05-27  Yoshifumi Inoue  <yosin@chromium.org>
 

trunk/Source/WTF/wtf/Vector.h

@@ -1111 +1111 @@
     inline void Vector<T, inlineCapacity>::remove(size_t position, size_t length)
     {
-        ASSERT(position < size());
+        ASSERT(position <= size());
         ASSERT(position + length <= size());
         T* beginSpot = begin() + position;