Changeset 118655 in webkit

Timestamp:

May 28, 2012, 1:53:45 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] http authentication crash the browser when user commit or cancel the http authentication dialog
​https://bugs.webkit.org/show_bug.cgi?id=87579

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-28
Reviewed by George Staikos.

In function NetworkJob::startNewJobWithRequest, We should cancel the
NetworkJob first before we start a new NetworkJob which reuses the
resource handle of the old one. If we only set the m_handle = 0 of the
old NetworkJob without cancelling itself, it will still receives data
notification from network thread and handles the received data with
the released resource handler, which will cause the crash.

No new tests because no behavior has changed.

• platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/blackberry/NetworkJob.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
+
+        [BlackBerry] http authentication crash the browser when user commit or cancel the http authentication dialog
+        https://bugs.webkit.org/show_bug.cgi?id=87579
+
+        Reviewed by George Staikos.
+
+        In function NetworkJob::startNewJobWithRequest, We should cancel the
+        NetworkJob first before we start a new NetworkJob which reuses the
+        resource handle of the old one. If we only set the m_handle = 0 of the
+        old NetworkJob without cancelling itself, it will still receives data
+        notification from network thread and handles the received data with
+        the released resource handler, which will cause the crash.
+
+        No new tests because no behavior has changed.
+
+        * platform/network/blackberry/NetworkJob.cpp:
+        (WebCore::NetworkJob::startNewJobWithRequest):
+
 2012-05-27  MORITA Hajime  <morrita@google.com>
 

trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp

@@ -529 +529 @@
     // Pass the ownership of the ResourceHandle to the new NetworkJob.
     RefPtr<ResourceHandle> handle = m_handle;
-    m_handle = 0;
-    m_multipartResponse = nullptr;
+    cancelJob();
 
     NetworkManager::instance()->startJob(m_playerId,