Changeset 118664 in webkit

Timestamp:

May 28, 2012, 2:54:00 AM (14 years ago)

Author:

morrita@google.com

Message:

HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()
​https://bugs.webkit.org/show_bug.cgi?id=87608

Reviewed by Kent Tamura.

Moved m_validationMessage clearance from detach() to removedFrom() and
remove detach().

No new tests. This change has no visible difference. Upcoming changes rely on this though.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::removedFrom):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLFormControlElement.cpp (modified) (2 diffs)
• html/HTMLFormControlElement.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-28  MORITA Hajime  <morrita@google.com>
+
+        HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()
+        https://bugs.webkit.org/show_bug.cgi?id=87608
+
+        Reviewed by Kent Tamura.
+
+        Moved m_validationMessage clearance from detach() to removedFrom() and
+        remove detach().
+
+        No new tests. This change has no visible difference. Upcoming changes rely on this though.
+
+        * html/HTMLFormControlElement.cpp:
+        (WebCore::HTMLFormControlElement::removedFrom):
+
 2012-05-28  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/html/HTMLFormControlElement.cpp

@@ -71 +71 @@
 }
 
-void HTMLFormControlElement::detach()
-{
-    m_validationMessage = nullptr;
-    HTMLElement::detach();
-}
-
 String HTMLFormControlElement::formEnctype() const
 {
@@ -234 +228 @@
 void HTMLFormControlElement::removedFrom(ContainerNode* insertionPoint)
 {
+    m_validationMessage = nullptr;
     m_fieldSetAncestorValid = false;
     m_dataListAncestorState = Unknown;

trunk/Source/WebCore/html/HTMLFormControlElement.h

@@ -131 +131 @@
 
     virtual void dispatchBlurEvent(PassRefPtr<Node> newFocusedNode);
-    virtual void detach();
 
     // This must be called any time the result of willValidate() has changed.