⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 118672 in webkit


Ignore:
Timestamp:
May 28, 2012, 3:23:41 AM (14 years ago)
Author:
peter@chromium.org
Message:

&AElig doesn't get rendered as U+00C6
​https://bugs.webkit.org/show_bug.cgi?id=87465

Reviewed by Adam Barth.

Source/WebCore:

The if-statement to check whether the first entry of a certain letter
already exists in the index used .get(). The very first alphabetical
entry is in position "0", which evaluates to false, causing the first
entry to be ignored. Instead, use a "x not in y" check here.

Also update WebCore.gyp to list the create-html-entity-table script as
an input for the action, to make sure the table will be recreated.

Test: html5lib/resources/entities02.dat

  • WebCore.gyp/WebCore.gyp:
  • html/parser/create-html-entity-table:

LayoutTests:

Test that the (current) first alphabetical entity in the named entity
table (&AElig, without a semi-colon) renders as expected.

  • html5lib/resources/entities02.dat:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r118667 r118672  
     12012-05-28  Peter Beverloo  <peter@chromium.org>
     2
     3        &AElig doesn't get rendered as U+00C6
     4        https://bugs.webkit.org/show_bug.cgi?id=87465
     5
     6        Reviewed by Adam Barth.
     7
     8        Test that the (current) first alphabetical entity in the named entity
     9        table (&AElig, without a semi-colon) renders as expected.
     10
     11        * html5lib/resources/entities02.dat:
     12
    1132012-05-28  Christophe Dumez  <christophe.dumez@intel.com>
    214

  • trunk/LayoutTests/html5lib/resources/entities02.dat

    r62241 r118672  
    248248|     <div>
    249249|       "ZZ&prod=23"
     250
     251#data
     252<div>ZZ&AElig=</div>
     253#errors
     254#document
     255| <html>
     256|   <head>
     257|   <body>
     258|     <div>
     259|       "ZZÆ="

  • trunk/Source/WebCore/ChangeLog

    r118670 r118672  
     12012-05-28  Peter Beverloo  <peter@chromium.org>
     2
     3        &AElig doesn't get rendered as U+00C6
     4        https://bugs.webkit.org/show_bug.cgi?id=87465
     5
     6        Reviewed by Adam Barth.
     7
     8        The if-statement to check whether the first entry of a certain letter
     9        already exists in the index used .get(). The very first alphabetical
     10        entry is in position "0", which evaluates to false, causing the first
     11        entry to be ignored. Instead, use a "x not in y" check here.
     12
     13        Also update WebCore.gyp to list the create-html-entity-table script as
     14        an input for the action, to make sure the table will be recreated.
     15
     16        Test: html5lib/resources/entities02.dat
     17
     18        * WebCore.gyp/WebCore.gyp:
     19        * html/parser/create-html-entity-table:
     20
    1212012-05-28  Yury Semikhatsky  <yurys@chromium.org>
    222

  • trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

    r118353 r118672  
    576576          'action_name': 'HTMLEntityTable',
    577577          'inputs': [
     578            '../html/parser/create-html-entity-table',
    578579            '../html/parser/HTMLEntityNames.in',
    579580          ],

  • trunk/Source/WebCore/html/parser/create-html-entity-table

    r103246 r118672  
    125125for entry in entries:
    126126    letter = entry[ENTITY][0]
    127     if not index.get(letter):
     127    if letter not in index:
    128128        index[letter] = offset
    129129    values = entry[VALUE].split(' ')
Note: See TracChangeset for help on using the changeset viewer.