Changeset 118673 in webkit

Timestamp:

May 28, 2012, 4:13:04 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r118580.
​http://trac.webkit.org/changeset/118580
​https://bugs.webkit.org/show_bug.cgi?id=87647

Caused webkit_unit_tests to crash on chromium. (Requested by
bulach on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-05-28

• platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(ContentLayerPainter):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

• platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::updateTiles):

• platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

• platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/ContentLayerChromium.cpp (modified) (3 diffs)
• platform/graphics/chromium/TiledLayerChromium.cpp (modified) (5 diffs)
• platform/graphics/chromium/TiledLayerChromium.h (modified) (3 diffs)
• platform/graphics/chromium/cc/CCLayerTreeHost.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-28  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r118580.
+        http://trac.webkit.org/changeset/118580
+        https://bugs.webkit.org/show_bug.cgi?id=87647
+
+        Caused webkit_unit_tests to crash on chromium. (Requested by
+        bulach on #webkit).
+
+        * platform/graphics/chromium/ContentLayerChromium.cpp:
+        (WebCore::ContentLayerPainter::create):
+        (WebCore::ContentLayerPainter::paint):
+        (WebCore::ContentLayerPainter::ContentLayerPainter):
+        (ContentLayerPainter):
+        (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
+        * platform/graphics/chromium/TiledLayerChromium.cpp:
+        (UpdatableTile):
+        (WebCore::UpdatableTile::UpdatableTile):
+        (WebCore::TiledLayerChromium::updateTiles):
+        * platform/graphics/chromium/TiledLayerChromium.h:
+        (TiledLayerChromium):
+        * platform/graphics/chromium/cc/CCLayerTreeHost.h:
+        (WebCore::CCSettings::CCSettings):
+        (CCSettings):
+
 2012-05-28  Peter Beverloo  <peter@chromium.org>
 

trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp

@@ -50 +50 @@
     WTF_MAKE_NONCOPYABLE(ContentLayerPainter);
 public:
-    static PassOwnPtr<ContentLayerPainter> create(ContentLayerDelegate* delegate, TiledLayerChromium* layer)
+    static PassOwnPtr<ContentLayerPainter> create(ContentLayerDelegate* delegate)
     {
-        return adoptPtr(new ContentLayerPainter(delegate, layer));
+        return adoptPtr(new ContentLayerPainter(delegate));
     }
 
@@ -60 +60 @@
         context.clearRect(contentRect);
         context.clip(contentRect);
-        {
-            GraphicsContextStateSaver stateSaver(context, m_layer->layerTreeHost()->settings().debugShowTileInfo);
-
-            m_delegate->paintContents(context, contentRect);
-            double paintEnd = currentTime();
-            double pixelsPerSec = (contentRect.width() * contentRect.height()) / (paintEnd - paintStart);
-            WebKit::Platform::current()->histogramCustomCounts("Renderer4.AccelContentPaintDurationMS", (paintEnd - paintStart) * 1000, 0, 120, 30);
-            WebKit::Platform::current()->histogramCustomCounts("Renderer4.AccelContentPaintMegapixPerSecond", pixelsPerSec / 1000000, 10, 210, 30);
-        }
-        if (m_layer->layerTreeHost()->settings().debugShowTileInfo)
-            m_layer->paintDebugTileInfo(context, contentRect);
+        m_delegate->paintContents(context, contentRect);
+        double paintEnd = currentTime();
+        double pixelsPerSec = (contentRect.width() * contentRect.height()) / (paintEnd - paintStart);
+        WebKit::Platform::current()->histogramCustomCounts("Renderer4.AccelContentPaintDurationMS", (paintEnd - paintStart) * 1000, 0, 120, 30);
+        WebKit::Platform::current()->histogramCustomCounts("Renderer4.AccelContentPaintMegapixPerSecond", pixelsPerSec / 1000000, 10, 210, 30);
     }
 private:
-    explicit ContentLayerPainter(ContentLayerDelegate* delegate, TiledLayerChromium* layer)
+    explicit ContentLayerPainter(ContentLayerDelegate* delegate)
         : m_delegate(delegate)
-        , m_layer(layer)
     {
     }
 
     ContentLayerDelegate* m_delegate;
-    TiledLayerChromium* m_layer;
 };
 
@@ -135 +127 @@
         return;
     if (layerTreeHost()->settings().acceleratePainting)
-        m_textureUpdater = FrameBufferSkPictureCanvasLayerTextureUpdater::create(ContentLayerPainter::create(m_delegate, this));
+        m_textureUpdater = FrameBufferSkPictureCanvasLayerTextureUpdater::create(ContentLayerPainter::create(m_delegate));
     else if (layerTreeHost()->settings().perTilePainting)
-        m_textureUpdater = BitmapSkPictureCanvasLayerTextureUpdater::create(ContentLayerPainter::create(m_delegate, this), layerTreeHost()->layerRendererCapabilities().usingMapSub);
+        m_textureUpdater = BitmapSkPictureCanvasLayerTextureUpdater::create(ContentLayerPainter::create(m_delegate), layerTreeHost()->layerRendererCapabilities().usingMapSub);
     else
-        m_textureUpdater = BitmapCanvasLayerTextureUpdater::create(ContentLayerPainter::create(m_delegate, this), layerTreeHost()->layerRendererCapabilities().usingMapSub);
+        m_textureUpdater = BitmapCanvasLayerTextureUpdater::create(ContentLayerPainter::create(m_delegate), layerTreeHost()->layerRendererCapabilities().usingMapSub);
     m_textureUpdater->setOpaque(opaque());
 

trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp

@@ -30 +30 @@
 #include "TiledLayerChromium.h"
 
-#include "FontCache.h"
-#include "FontDescription.h"
 #include "GraphicsContext3D.h"
 #include "LayerRendererChromium.h"
 #include "ManagedTexture.h"
 #include "Region.h"
-#include "TextRun.h"
 #include "TextStream.h"
 #include "TraceEvent.h"
@@ -77 +74 @@
     bool updated;
     bool isInUseOnImpl;
-    int lastUpdateFrame;
-    int totalPaintCount;
 private:
     explicit UpdatableTile(PassOwnPtr<LayerTextureUpdater::Texture> texture)
@@ -84 +79 @@
         , updated(false)
         , isInUseOnImpl(false)
-        , lastUpdateFrame(0)
-        , totalPaintCount(0)
         , m_texture(texture)
     {
@@ -415 +408 @@
                 }
                 return;
-            }
-
-            if (tile->isDirty() && layerTreeHost()->settings().debugShowTileInfo) {
-                // Invalidate the entire tile so that text updates.
-                tile->dirtyRect = m_tiler->tileRect(tile);
-                tile->lastUpdateFrame = layerTreeHost()->frameNumber();
-                tile->totalPaintCount++;
             }
 
@@ -727 +713 @@
 }
 
-void TiledLayerChromium::paintDebugTileInfo(GraphicsContext& context, const IntRect& layerRect)
-{
-    FontCachePurgePreventer fontCachePurgePreventer;
-
-    // Don't bother writing info onto small tiles.
-    const int minDimension = 200;
-    if (m_tiler->tileSize().width() < minDimension || m_tiler->tileSize().height() < minDimension)
-        return;
-
-    if (!m_debugInfoFont) {
-        FontDescription fontDesc;
-        fontDesc.setGenericFamily(FontDescription::MonospaceFamily);
-        fontDesc.setComputedSize(10);
-        m_debugInfoFont = adoptPtr(new Font(fontDesc, 0, 0));
-        m_debugInfoFont->update(0);
-    }
-
-    int fontHeight = m_debugInfoFont->fontMetrics().floatHeight() + 2;
-
-    int left, top, right, bottom;
-    m_tiler->layerRectToTileIndices(layerRect, left, top, right, bottom);
-    for (int j = top; j <= bottom; ++j) {
-        for (int i = left; i <= right; ++i) {
-            UpdatableTile* tile = tileAt(i, j);
-            if (!tile)
-                continue;
-
-            IntRect tileRect = m_tiler->tileRect(tile);
-            String info[] = {
-                String::format("LayerId(%d)", id()),
-                String::format("Index(%d, %d)", i, j),
-                String::format("Tile(%d, %d, %d, %d)", tileRect.x(), tileRect.y(), tileRect.width(), tileRect.height()),
-                String::format("Frame(%d)", tile->lastUpdateFrame),
-                String::format("Count(%d)", tile->totalPaintCount),
-                String::format("Layer(%d, %d)", contentBounds().width(), contentBounds().height()),
-            };
-            const size_t lines = sizeof(info) / sizeof(info[0]);
-            int width[lines];
-
-            IntPoint center = m_tiler->tileRect(tile).center();
-            int currentY = center.y() - fontHeight * lines / 2;
-
-            int maxWidth = 0;
-            for (size_t i = 0; i < lines; ++i) {
-                width[i] = m_debugInfoFont->width(TextRun(info[i]));
-                maxWidth = max(width[i], maxWidth);
-            }
-
-            IntRect textRect(IntPoint(center.x() - maxWidth / 2, currentY - fontHeight / 2), IntSize(maxWidth, fontHeight * lines + fontHeight / 2));
-
-            context.setFillColor(Color(192, 192, 192, 192), ColorSpaceDeviceRGB);
-            context.fillRect(FloatRect(textRect));
-
-            context.setFillColor(Color(64, 64, 64), ColorSpaceDeviceRGB);
-
-            for (size_t i = 0; i < lines; ++i) {
-                TextRun run(info[i]);
-                int textWidth = m_debugInfoFont->width(run);
-                IntPoint textStart(center.x() - textWidth / 2, currentY + fontHeight / 2);
-                context.drawText(*m_debugInfoFont, run, textStart);
-                currentY += fontHeight;
-            }
-        }
-    }
-}
-
 }
 #endif // USE(ACCELERATED_COMPOSITING)

trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h

@@ -29 +29 @@
 #if USE(ACCELERATED_COMPOSITING)
 
-#include "Font.h"
 #include "LayerChromium.h"
 #include "cc/CCLayerTilingData.h"
@@ -66 +65 @@
 
     virtual Region visibleContentOpaqueRegion() const OVERRIDE;
-
-    void paintDebugTileInfo(GraphicsContext&, const IntRect&);
 
 protected:
@@ -131 +128 @@
     TilingOption m_tilingOption;
     OwnPtr<CCLayerTilingData> m_tiler;
-    OwnPtr<Font> m_debugInfoFont;
 };
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h

@@ -78 +78 @@
     CCSettings()
             : acceleratePainting(false)
-            , debugShowTileInfo(false)
             , showFPSCounter(false)
             , showPlatformLayerTree(false)
@@ -95 +94 @@
 
     bool acceleratePainting;
-    bool debugShowTileInfo;
     bool showFPSCounter;
     bool showPlatformLayerTree;