Changeset 118885 in webkit

Timestamp:

May 29, 2012, 8:30:23 PM (14 years ago)

Author:

macpherson@chromium.org

Message:

Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
​https://bugs.webkit.org/show_bug.cgi?id=87684

Reviewed by Darin Adler.

Darin provided some style suggesting on ​https://bugs.webkit.org/show_bug.cgi?id=87462 after it landed.
This patch incorporates those suggestions, namely using 0 instead of empty string for UnknownTransformOperation
and WTF_ARRAY_LENGTH instead of hard coding the array length.

Covered by existing transform tests.

• css/WebKitCSSTransformValue.cpp:

(WebCore):
(WebCore::WebKitCSSTransformValue::customCssText):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/WebKitCSSTransformValue.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-29  Luke Macpherson  <macpherson@chromium.org>
+
+        Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
+        https://bugs.webkit.org/show_bug.cgi?id=87684
+
+        Reviewed by Darin Adler.
+
+        Darin provided some style suggesting on https://bugs.webkit.org/show_bug.cgi?id=87462 after it landed.
+        This patch incorporates those suggestions, namely using 0 instead of empty string for UnknownTransformOperation
+        and WTF_ARRAY_LENGTH instead of hard coding the array length.
+
+        Covered by existing transform tests.
+
+        * css/WebKitCSSTransformValue.cpp:
+        (WebCore):
+        (WebCore::WebKitCSSTransformValue::customCssText):
+
 2012-05-29  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebCore/css/WebKitCSSTransformValue.cpp

@@ -34 +34 @@
 namespace WebCore {
 
-const int transformNameSize = 22;
-const char* const transformName[transformNameSize] = {
-     "",
+// These names must be kept in sync with TransformOperationType.
+const char* const transformName[] = {
+     0,
      "translate",
      "translateX",
@@ -70 +70 @@
     StringBuilder result;
     if (m_type != UnknownTransformOperation) {
-        ASSERT(m_type < transformNameSize);
+        ASSERT(static_cast<size_t>(m_type) < WTF_ARRAY_LENGTH(transformName));
         result.append(transformName[m_type]);
         result.append('(');