Changeset 118888 in webkit

Timestamp:

May 29, 2012, 9:03:07 PM (14 years ago)

Author:

tkent@chromium.org

Message:

Fix inefficient usage of traverseNextNode()
​https://bugs.webkit.org/show_bug.cgi?id=87804

Reviewed by Ryosuke Niwa.

foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
firstChild() is more efficient.

No new tests because of no behavior change.

• html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
Replace traverseNextNode() with firstChild(), and shorten a variable name.

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):
Replace traverseNextNode() with firstChild().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLFieldSetElement.cpp (modified) (1 diff)
• svg/SVGSVGElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-05-29  Kent Tamura  <tkent@chromium.org>
+
+        Fix inefficient usage of traverseNextNode()
+        https://bugs.webkit.org/show_bug.cgi?id=87804
+
+        Reviewed by Ryosuke Niwa.
+
+        foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
+        firstChild() is more efficient.
+
+        No new tests because of no behavior change.
+
+        * html/HTMLFieldSetElement.cpp:
+        (WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
+        Replace traverseNextNode() with firstChild(), and shorten a variable name.
+        * svg/SVGSVGElement.cpp:
+        (WebCore::SVGSVGElement::getElementById):
+        Replace traverseNextNode() with firstChild().
+
 2012-05-29  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
 

trunk/Source/WebCore/html/HTMLFieldSetElement.cpp

@@ -50 +50 @@
 void HTMLFieldSetElement::invalidateDisabledStateUnder(Element* base)
 {
-    for (Node* currentNode = base->traverseNextNode(base); currentNode; currentNode = currentNode->traverseNextNode(base)) {
-        if (currentNode && currentNode->isElementNode() && toElement(currentNode)->isFormControlElement())
-            static_cast<HTMLFormControlElement*>(currentNode)->ancestorDisabledStateWasChanged();
+    for (Node* node = base->firstChild(); node; node = node->traverseNextNode(base)) {
+        if (node->isElementNode() && toElement(node)->isFormControlElement())
+            static_cast<HTMLFormControlElement*>(node)->ancestorDisabledStateWasChanged();
     }
 }

trunk/Source/WebCore/svg/SVGSVGElement.cpp

@@ -755 +755 @@
     // Fall back to traversing our subtree. Duplicate ids are allowed, the first found will
     // be returned.
-    for (Node* node = traverseNextNode(this); node; node = node->traverseNextNode(this)) {
+    for (Node* node = firstChild(); node; node = node->traverseNextNode(this)) {
         if (!node->isElementNode())
             continue;