Changeset 119458 in webkit

Timestamp:

Jun 4, 2012, 10:01:57 PM (14 years ago)

Author:

Simon Fraser

Message:

Leaking ClipRects
​https://bugs.webkit.org/show_bug.cgi?id=88282

Reviewed by Dan Bernstein.

In r118562 I made the ClipRectsCache use RefPtr<ClipRects>. However, ClipRects
was initialized with m_refCnt=0, not 1 as adoptRef() and friends expect. Also,
there was a manual ref() in RenderLayer::updateClipRects() which this patch removes.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateClipRects):

• rendering/RenderLayer.h:

(WebCore::ClipRects::ClipRects):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayer.cpp (modified) (1 diff)
• rendering/RenderLayer.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-04  Simon Fraser  <simon.fraser@apple.com>
+
+        Leaking ClipRects
+        https://bugs.webkit.org/show_bug.cgi?id=88282
+
+        Reviewed by Dan Bernstein.
+
+        In r118562 I made the ClipRectsCache use RefPtr<ClipRects>. However, ClipRects
+        was initialized with m_refCnt=0, not 1 as adoptRef() and friends expect. Also,
+        there was a manual ref() in RenderLayer::updateClipRects() which this patch removes.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::updateClipRects):
+        * rendering/RenderLayer.h:
+        (WebCore::ClipRects::ClipRects):
+
 2012-06-04  Emil A Eklund  <eae@chromium.org> and Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -3795 +3795 @@
         m_clipRectsCache->m_clipRects[clipRectsType] = ClipRects::create(clipRects);
 
-    m_clipRectsCache->m_clipRects[clipRectsType]->ref();
 #ifndef NDEBUG
     m_clipRectsCache->m_clipRectsRoot[clipRectsType] = rootLayer;

trunk/Source/WebCore/rendering/RenderLayer.h

@@ -141 +141 @@
 
     ClipRects()
-        : m_refCnt(0)
+        : m_refCnt(1)
         , m_fixed(false)
     {
@@ -195 +195 @@
         , m_fixedClipRect(r)
         , m_posClipRect(r)
-        , m_refCnt(0)
+        , m_refCnt(1)
         , m_fixed(false)
     {
@@ -204 +204 @@
         , m_fixedClipRect(other.fixedClipRect())
         , m_posClipRect(other.posClipRect())
-        , m_refCnt(0)
+        , m_refCnt(1)
         , m_fixed(other.fixed())
     {