Changeset 119469 in webkit

Timestamp:

Jun 5, 2012, 1:56:24 AM (14 years ago)

Author:

apavlov@chromium.org

Message:

Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
​https://bugs.webkit.org/show_bug.cgi?id=88257

Reviewed by Pavel Feldman.

Source/WebCore:

Canonical names for properties should be used when checking if they are inherited (since only canonical names
are put into the usedProperties set).

• inspector/front-end/StylesSidebarPane.js:

(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

LayoutTests:

• inspector/elements/elements-panel-styles-expected.txt:
• inspector/elements/elements-panel-styles.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/elements/elements-panel-styles-expected.txt (modified) (2 diffs)
• LayoutTests/inspector/elements/elements-panel-styles.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/StylesSidebarPane.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-06-05  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
+        https://bugs.webkit.org/show_bug.cgi?id=88257
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/elements/elements-panel-styles-expected.txt:
+        * inspector/elements/elements-panel-styles.html:
+
 2012-06-05  Kenichi Ishibashi  <bashi@chromium.org>
 

trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt

@@ -2 +2 @@
 
 [expanded] 
+-webkit-font-smoothing: subpixel-antialiased;
+    element.style - subpixel-antialiased 
 border-bottom-left-radius: 5px;
     .foo - 5px elements-panel-styles.css:14
@@ -38 +40 @@
 element.style  { ()
 display: none;
+-webkit-font-smoothing: subpixel-antialiased;
 
 ======== Matched CSS Rules ========

trunk/LayoutTests/inspector/elements/elements-panel-styles.html

@@ -27 +27 @@
 
 <div id="container">
-    <div id="foo" class="foo" style="display:none" align="left">Foo</div>
+    <div id="foo" class="foo" style="display:none; -webkit-font-smoothing: subpixel-antialiased;" align="left">Foo</div>
 </div>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-05  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
+        https://bugs.webkit.org/show_bug.cgi?id=88257
+
+        Reviewed by Pavel Feldman.
+
+        Canonical names for properties should be used when checking if they are inherited (since only canonical names
+        are put into the usedProperties set).
+
+        * inspector/front-end/StylesSidebarPane.js:
+        (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):
+
 2012-06-05  Kenichi Ishibashi  <bashi@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js

@@ -1398 +1398 @@
     _isPropertyInherited: function(propertyName)
     {
-        return !(propertyName in this._usedProperties) && !(propertyName in this._alwaysShowComputedProperties);
+        var canonicalName = WebInspector.StylesSidebarPane.canonicalPropertyName(propertyName);
+        return !(canonicalName in this._usedProperties) && !(canonicalName in this._alwaysShowComputedProperties);
     },