Changeset 119479 in webkit

Timestamp:

Jun 5, 2012, 3:57:00 AM (14 years ago)

Author:

kinuko@chromium.org

Message:

Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
​https://bugs.webkit.org/show_bug.cgi?id=85174

Reviewed by Kentaro Hara.

Source/WebCore:

This fixes a crash problem which could happen when the constructor is
given an array which contains String-type item(s).

There're still some Text mismatches between v8 results and
JSC results, most of them are v8 not throwing exception
when it is given an object whose toString() method throws
exception. (The issue will be addresse in a separate patch.)

Test: fast/files/blob-constructor.html

• bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

LayoutTests:

Changing blob-constructor.html label from CRASH to TEXT.

• platform/chromium/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-06-04  Kinuko Yasuda  <kinuko@chromium.org>
+
+        Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=85174
+
+        Reviewed by Kentaro Hara.
+
+        Changing blob-constructor.html label from CRASH to TEXT.
+
+        * platform/chromium/TestExpectations:
+
 2012-06-05  Kenichi Ishibashi  <bashi@chromium.org>
 

trunk/LayoutTests/platform/chromium/TestExpectations

@@ -3613 +3613 @@
 BUGWK85106 SLOW : tables/mozilla/other/slashlogo.html = PASS
 
-BUGWK85174 : fast/files/blob-constructor.html = CRASH
+BUGWK85174 : fast/files/blob-constructor.html = TEXT
 BUGWK85174 : fast/dom/HTMLAnchorElement/anchor-download-unset.html = TIMEOUT
 BUGWK85174 : fast/filesystem/file-writer-gc-blob.html = TIMEOUT

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-04  Kinuko Yasuda  <kinuko@chromium.org>
+
+        Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=85174
+
+        Reviewed by Kentaro Hara.
+
+        This fixes a crash problem which could happen when the constructor is
+        given an array which contains String-type item(s).
+
+        There're still some Text mismatches between v8 results and
+        JSC results, most of them are v8 not throwing exception
+        when it is given an object whose toString() method throws
+        exception.  (The issue will be addresse in a separate patch.)
+
+        Test: fast/files/blob-constructor.html
+
+        * bindings/v8/custom/V8BlobCustom.cpp:
+        (WebCore::V8Blob::constructorCallback):
+
 2012-06-05  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp

@@ -127 +127 @@
             blobBuilder->append(blob);
         } else {
-            EXCEPTION_BLOCK(String, stringValue, toWebCoreString(item->ToString()));
+            EXCEPTION_BLOCK(String, stringValue, toWebCoreString(item));
             blobBuilder->append(stringValue, endings, ASSERT_NO_EXCEPTION);
         }