Changeset 120404 in webkit

Timestamp:

Jun 14, 2012, 11:16:14 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[BlackBerry] Selection - Crash when manipulating selection by dragging handle
​https://bugs.webkit.org/show_bug.cgi?id=89160

RIMBUG:164970
Avoid to set position in shadow tree to the new selection's base. It
crashes when setting a shadow position to a selection' base.

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-06-14
Reviewed by Antonio Gomes.

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/SelectionHandler.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-06-14  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>
+
+        [BlackBerry] Selection - Crash when manipulating selection by dragging handle
+        https://bugs.webkit.org/show_bug.cgi?id=89160
+
+        RIMBUG:164970
+        Avoid to set position in shadow tree to the new selection's base. It
+        crashes when setting a shadow position to a selection' base.
+
+        Reviewed by Antonio Gomes.
+
+        * WebKitSupport/SelectionHandler.cpp:
+        (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
+
 2012-06-14  Mary Wu  <mary.wu@torchmobile.com.cn>
 

trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp

@@ -153 +153 @@
     // visiblePositionAtPoint which which passes ignoreClipping=true.
     // See RIM Bug #4315.
-    HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, true /* allowShadowContent */, true /* ignoreClipping */);
+    HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, false /* allowShadowContent */, true /* ignoreClipping */);
 
     Node* node = result.innerNode();