Changeset 120434 in webkit

Timestamp:

Jun 15, 2012, 2:58:10 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r120404.
​http://trac.webkit.org/changeset/120404
​https://bugs.webkit.org/show_bug.cgi?id=89193

This patch breaks [BlackBerry]'s text selection handles moving
in editable elements. (Requested by Sean1 on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-15

• WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebKitSupport/SelectionHandler.cpp (modified) (1 diff)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r120404.
+        http://trac.webkit.org/changeset/120404
+        https://bugs.webkit.org/show_bug.cgi?id=89193
+
+        This patch breaks [BlackBerry]'s text selection handles moving
+        in editable elements. (Requested by Sean1 on #webkit).
+
+        * WebKitSupport/SelectionHandler.cpp:
+        (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
+
 2012-06-14  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>
 

trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp

@@ -153 +153 @@
     // visiblePositionAtPoint which which passes ignoreClipping=true.
     // See RIM Bug #4315.
-    HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, false /* allowShadowContent */, true /* ignoreClipping */);
+    HitTestResult result = frame.eventHandler()->hitTestResultAtPoint(framePoint, true /* allowShadowContent */, true /* ignoreClipping */);
 
     Node* node = result.innerNode();