Changeset 120464 in webkit

Timestamp:

Jun 15, 2012, 8:37:12 AM (14 years ago)

Author:

schenney@chromium.org

Message:

SVG Composite of Offset filters incorrectly clips
​https://bugs.webkit.org/show_bug.cgi?id=77660

Reviewed by Dirk Schulze.

Source/WebCore:

Prior to this patch, when a group of filtered objects was used as input to another filter,
the filter only operated on the stroke boundary of the group, and hence excluded the results
of filtering elements within the group, or extraneously included regions clipped from the
elements in the group.

This patch modifies the strokeBoundingBox of SVG container elements to
be the union of the repaint rects for the children. This modifes the
results returned for sizing filters and for absoluteRects, which will cause
inline layout around the group to factor in the resources applied to
the group's children.

The relevant spec entry is this, in Section 3.7 of the SVG 1.1 spec: "...the result must be
as though the paint operations had been applied to an intermediate canvas initialized to
transparent black, of a size determined by the rules given in Filter Effects then filtered
by the processes defined in Filter Effects." In this case the "paint operations" is implied
to include the result of applying "paint" but no resources to the group, which in turn would
have resources applied to the children of the group. This makes the most sense, as the current,
incorrect behavior makes it extremely diffucult to understand the actions of filters on
groups of filtered content.

Tests: svg/filters/container-with-filters-expected.svg

svg/filters/container-with-filters.svg

• rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::updateCachedBoundaries):

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::updateCachedBoundaries):

• rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

LayoutTests:

• svg/filters/container-with-filters-expected.svg: Added.
• svg/filters/container-with-filters.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/filters/container-with-filters-expected.svg (added)
• LayoutTests/svg/filters/container-with-filters.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGContainer.cpp (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGRoot.cpp (modified) (1 diff)
• Source/WebCore/rendering/svg/SVGRenderSupport.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-06-15  Stephen Chenney  <schenney@chromium.org>
+
+        SVG Composite of Offset filters incorrectly clips
+        https://bugs.webkit.org/show_bug.cgi?id=77660
+
+        Reviewed by Dirk Schulze.
+
+        * svg/filters/container-with-filters-expected.svg: Added.
+        * svg/filters/container-with-filters.svg: Added.
+
 2012-06-15  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-15  Stephen Chenney  <schenney@chromium.org>
+
+        SVG Composite of Offset filters incorrectly clips
+        https://bugs.webkit.org/show_bug.cgi?id=77660
+
+        Reviewed by Dirk Schulze.
+
+        Prior to this patch, when a group of filtered objects was used as input to another filter,
+        the filter only operated on the stroke boundary of the group, and hence excluded the results
+        of filtering elements within the group, or extraneously included regions clipped from the
+        elements in the group.
+
+        This patch modifies the strokeBoundingBox of SVG container elements to
+        be the union of the repaint rects for the children. This modifes the
+        results returned for sizing filters and for absoluteRects, which will cause
+        inline layout around the group to factor in the resources applied to
+        the group's children.
+
+        The relevant spec entry is this, in Section 3.7 of the SVG 1.1 spec: "...the result must be
+        as though the paint operations had been applied to an intermediate canvas initialized to
+        transparent black, of a size determined by the rules given in Filter Effects then filtered
+        by the processes defined in Filter Effects." In this case the "paint operations" is implied
+        to include the result of applying "paint" but no resources to the group, which in turn would
+        have resources applied to the children of the group. This makes the most sense, as the current,
+        incorrect behavior makes it extremely diffucult to understand the actions of filters on
+        groups of filtered content.
+
+        Tests: svg/filters/container-with-filters-expected.svg
+               svg/filters/container-with-filters.svg
+
+        * rendering/svg/RenderSVGContainer.cpp:
+        (WebCore::RenderSVGContainer::updateCachedBoundaries):
+        * rendering/svg/RenderSVGRoot.cpp:
+        (WebCore::RenderSVGRoot::updateCachedBoundaries):
+        * rendering/svg/SVGRenderSupport.cpp:
+        (WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
+
 2012-06-15  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp

@@ -164 +164 @@
 void RenderSVGContainer::updateCachedBoundaries()
 {
-    m_objectBoundingBox = FloatRect();
-    m_objectBoundingBoxValid = false;
-    m_strokeBoundingBox = FloatRect();
-    m_repaintBoundingBox = FloatRect();
-
     SVGRenderSupport::computeContainerBoundingBoxes(this, m_objectBoundingBox, m_objectBoundingBoxValid, m_strokeBoundingBox, m_repaintBoundingBox);
     SVGRenderSupport::intersectRepaintRectWithResources(this, m_repaintBoundingBox);

trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp

@@ -405 +405 @@
 void RenderSVGRoot::updateCachedBoundaries()
 {
-    m_objectBoundingBox = FloatRect();
-    m_objectBoundingBoxValid = false;
-    m_strokeBoundingBox = FloatRect();
-    m_repaintBoundingBox = FloatRect();
-
     SVGRenderSupport::computeContainerBoundingBoxes(this, m_objectBoundingBox, m_objectBoundingBoxValid, m_strokeBoundingBox, m_repaintBoundingBox);
     SVGRenderSupport::intersectRepaintRectWithResources(this, m_repaintBoundingBox);

trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp

@@ -122 +122 @@
 void SVGRenderSupport::computeContainerBoundingBoxes(const RenderObject* container, FloatRect& objectBoundingBox, bool& objectBoundingBoxValid, FloatRect& strokeBoundingBox, FloatRect& repaintBoundingBox)
 {
+    objectBoundingBox = FloatRect();
+    objectBoundingBoxValid = false;
+    strokeBoundingBox = FloatRect();
+
+    // When computing the strokeBoundingBox, we use the repaintRects of the container's children so that the container's stroke includes
+    // the resources applied to the children (such as clips and filters). This allows filters applied to containers to correctly bound
+    // the children, and also improves inlining of SVG content, as the stroke bound is used in that situation also.
     for (RenderObject* current = container->firstChild(); current; current = current->nextSibling()) {
         if (current->isSVGHiddenContainer())
@@ -129 +136 @@
         if (transform.isIdentity()) {
             updateObjectBoundingBox(objectBoundingBox, objectBoundingBoxValid, current, current->objectBoundingBox());
-            strokeBoundingBox.unite(current->strokeBoundingBox());
-            repaintBoundingBox.unite(current->repaintRectInLocalCoordinates());
+            strokeBoundingBox.unite(current->repaintRectInLocalCoordinates());
         } else {
             updateObjectBoundingBox(objectBoundingBox, objectBoundingBoxValid, current, transform.mapRect(current->objectBoundingBox()));
-            strokeBoundingBox.unite(transform.mapRect(current->strokeBoundingBox()));
-            repaintBoundingBox.unite(transform.mapRect(current->repaintRectInLocalCoordinates()));
+            strokeBoundingBox.unite(transform.mapRect(current->repaintRectInLocalCoordinates()));
         }
     }
+
+    repaintBoundingBox = strokeBoundingBox;
 }