Changeset 120470 in webkit

Timestamp:

Jun 15, 2012, 9:48:21 AM (14 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: CRASH when DebuggerAgent.setBreakpoint was called twice for the same location.
​https://bugs.webkit.org/show_bug.cgi?id=89225

Reviewed by Pavel Feldman.

• inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpoint):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorDebuggerAgent.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-06-15  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: CRASH when DebuggerAgent.setBreakpoint was called twice for the same location.
+        https://bugs.webkit.org/show_bug.cgi?id=89225
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/InspectorDebuggerAgent.cpp:
+        (WebCore::InspectorDebuggerAgent::setBreakpoint):
+
 2012-06-08  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp

@@ -274 +274 @@
 
     String breakpointId = scriptId + ':' + String::number(lineNumber) + ':' + String::number(columnNumber);
-    if (m_breakpointIdToDebugServerBreakpointIds.find(breakpointId) != m_breakpointIdToDebugServerBreakpointIds.end())
-        return;
+    if (m_breakpointIdToDebugServerBreakpointIds.find(breakpointId) != m_breakpointIdToDebugServerBreakpointIds.end()) {
+        *errorString = "Breakpoint at specified location already exists.";
+        return;
+    }
     ScriptBreakpoint breakpoint(lineNumber, columnNumber, condition);
     actualLocation = resolveBreakpoint(breakpointId, scriptId, breakpoint);