⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 121130 in webkit


Ignore:
Timestamp:
Jun 24, 2012, 7:14:26 PM (14 years ago)
Author:
Antti Koivisto
Message:

REGRESSION(r121124): LayoutTests/fast/block/inline-children-root-linebox-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=89844

Reviewed by Dan Bernstein.

We need to check for the flipped writing mode and take the slow path if it is used.

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::pushMappingsToAncestor):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r121129 r121130  
     12012-06-24  Antti Koivisto  <antti@apple.com>
     2
     3        REGRESSION(r121124): LayoutTests/fast/block/inline-children-root-linebox-crash.html asserts
     4        https://bugs.webkit.org/show_bug.cgi?id=89844
     5       
     6        Reviewed by Dan Bernstein.
     7
     8        We need to check for the flipped writing mode and take the slow path if it is used.
     9
     10        * rendering/RenderGeometryMap.cpp:
     11        (WebCore::RenderGeometryMap::pushMappingsToAncestor):
     12
    1132012-06-24  Luke Macpherson  <macpherson@chromium.org>
    214
  • trunk/Source/WebCore/rendering/RenderGeometryMap.cpp

    r121124 r121130  
    186186
    187187    // The simple case can be handled fast in the layer tree.
    188     bool canConvertInLayerTree = ancestorLayer && renderer->style()->position() != FixedPosition;
     188    bool canConvertInLayerTree = ancestorLayer && renderer->style()->position() != FixedPosition && !renderer->style()->isFlippedBlocksWritingMode();
    189189    for (const RenderLayer* current = layer; current != ancestorLayer && canConvertInLayerTree; current = current->parent())
    190190        canConvertInLayerTree = current->canUseConvertToLayerCoords();
Note: See TracChangeset for help on using the changeset viewer.