Changeset 124489 in webkit

Timestamp:

Aug 2, 2012 1:30:15 PM (12 years ago)

Author:

Beth Dakin

Message:

​https://bugs.webkit.org/show_bug.cgi?id=93020
REGRESSION (tiled scrolling): Full-screen video is broken if page is
scrolled
-and corresponding-
<rdar://problem/11629778>

Reviewed by Anders Carlsson.

The bug here is that ScrollingTreeNodeMac::setScrollLayerPosition()
uses the CALayer (PlatformLayer) directly to set the position. That
means that the GraphicsLayer that owns that PlatformLayer does not
have updated position information. That results in this bug when we
switch from fast scrolling to main thread scrolling, because at that
point, the GraphicsLayer needs to have the correct information. So
make sure to update the main thread scroll position and layer
position before transitioning to main thread scrolling.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ScrollingCoordinator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-02  Beth Dakin  <bdakin@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=93020
+        REGRESSION (tiled scrolling): Full-screen video is broken if page is 
+        scrolled
+        -and corresponding-
+        <rdar://problem/11629778>
+
+        Reviewed by Anders Carlsson.
+
+        The bug here is that ScrollingTreeNodeMac::setScrollLayerPosition() 
+        uses the CALayer (PlatformLayer) directly to set the position. That 
+        means that the GraphicsLayer that owns that PlatformLayer does not 
+        have updated position information. That results in this bug when we 
+        switch from fast scrolling to main thread scrolling, because at that 
+        point, the GraphicsLayer needs to have the correct information. So 
+        make sure to update the main thread scroll position and layer 
+        position before transitioning to main thread scrolling.
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
+
 2012-08-02  Addy Osmani  <addyo@chromium.org>
 

trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -416 +416 @@
 void ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread(bool shouldUpdateScrollLayerPositionOnMainThread)
 {
+    // The FrameView's GraphicsLayer is likely to be out-of-synch with the PlatformLayer
+    // at this point. So we'll update it before we switch back to main thread scrolling
+    // in order to avoid layer positioning bugs.
+    if (shouldUpdateScrollLayerPositionOnMainThread)
+        updateMainFrameScrollPositionAndScrollLayerPosition();
     m_scrollingTreeState->setShouldUpdateScrollLayerPositionOnMainThread(shouldUpdateScrollLayerPositionOnMainThread);
     scheduleTreeStateCommit();