Changeset 125734 in webkit

Timestamp:

Aug 15, 2012, 6:41:37 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

Improve Document.h compile time - reduce includes of ScriptCallStack.h
​https://bugs.webkit.org/show_bug.cgi?id=94161

Patch by Nikhil Bhargava <​nbhargava@google.com> on 2012-08-15
Reviewed by Eric Seidel.

ScriptCallStack.h no longer included from ScriptExecutionContext. It's
relatively expensive to compile and gets compiled a ton because
Document.h indirectly includes it.

No new tests. Functionality should remain the same

• Modules/indexeddb/IDBDatabase.cpp:
• Modules/indexeddb/IDBIndex.cpp:
• Modules/indexeddb/IDBObjectStore.cpp:
• bindings/js/ScriptController.cpp:
• dom/ScriptElement.cpp:
• dom/ScriptExecutionContext.h:

(WebCore):

• fileapi/Blob.cpp:
• fileapi/WebKitBlobBuilder.cpp:
• html/HTMLTrackElement.cpp:
• loader/TextTrackLoader.cpp:
• page/DOMSecurityPolicy.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/IDBDatabase.cpp (modified) (1 diff)
• Modules/indexeddb/IDBIndex.cpp (modified) (1 diff)
• Modules/indexeddb/IDBObjectStore.cpp (modified) (1 diff)
• bindings/js/ScriptController.cpp (modified) (1 diff)
• dom/ScriptElement.cpp (modified) (1 diff)
• dom/ScriptExecutionContext.h (modified) (2 diffs)
• fileapi/Blob.cpp (modified) (1 diff)
• fileapi/WebKitBlobBuilder.cpp (modified) (1 diff)
• html/HTMLTrackElement.cpp (modified) (1 diff)
• loader/TextTrackLoader.cpp (modified) (1 diff)
• page/DOMSecurityPolicy.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-15  Nikhil Bhargava  <nbhargava@google.com>
+
+        Improve Document.h compile time - reduce includes of ScriptCallStack.h
+        https://bugs.webkit.org/show_bug.cgi?id=94161
+
+        Reviewed by Eric Seidel.
+
+        ScriptCallStack.h no longer included from ScriptExecutionContext. It's
+        relatively expensive to compile and gets compiled a ton because
+        Document.h indirectly includes it.
+
+        No new tests. Functionality should remain the same
+
+        * Modules/indexeddb/IDBDatabase.cpp:
+        * Modules/indexeddb/IDBIndex.cpp:
+        * Modules/indexeddb/IDBObjectStore.cpp:
+        * bindings/js/ScriptController.cpp:
+        * dom/ScriptElement.cpp:
+        * dom/ScriptExecutionContext.h:
+        (WebCore):
+        * fileapi/Blob.cpp:
+        * fileapi/WebKitBlobBuilder.cpp:
+        * html/HTMLTrackElement.cpp:
+        * loader/TextTrackLoader.cpp:
+        * page/DOMSecurityPolicy.cpp:
+
 2012-08-15  Alec Flett  <alecflett@chromium.org>
 

trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp

@@ -44 +44 @@
 #include "IDBVersionChangeEvent.h"
 #include "IDBVersionChangeRequest.h"
+#include "ScriptCallStack.h"
 #include "ScriptExecutionContext.h"
 #include <limits>

trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp

@@ -38 +38 @@
 #include "IDBTracing.h"
 #include "IDBTransaction.h"
+#include "ScriptCallStack.h"
 
 namespace WebCore {

trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp

@@ -42 +42 @@
 #include "IDBTracing.h"
 #include "IDBTransaction.h"
+#include "ScriptCallStack.h"
 #include "SerializedScriptValue.h"
 #include <wtf/UnusedParam.h>

trunk/Source/WebCore/bindings/js/ScriptController.cpp

@@ -37 +37 @@
 #include "PageGroup.h"
 #include "PluginView.h"
+#include "ScriptCallStack.h"
 #include "ScriptSourceCode.h"
 #include "ScriptValue.h"

trunk/Source/WebCore/dom/ScriptElement.cpp

@@ -39 +39 @@
 #include "MIMETypeRegistry.h"
 #include "Page.h"
+#include "ScriptCallStack.h"
 #include "ScriptRunner.h"
 #include "ScriptSourceCode.h"

trunk/Source/WebCore/dom/ScriptExecutionContext.h

@@ -32 +32 @@
 #include "ConsoleTypes.h"
 #include "KURL.h"
-#include "ScriptCallStack.h"
 #include "SecurityContext.h"
 #include "Supplementable.h"
@@ -55 +54 @@
 class EventTarget;
 class MessagePort;
+class ScriptCallStack;
 
 #if ENABLE(BLOB)

trunk/Source/WebCore/fileapi/Blob.cpp

@@ -35 +35 @@
 #include "File.h"
 #include "HistogramSupport.h"
+#include "ScriptCallStack.h"
 #include "ScriptExecutionContext.h"
 #include "ThreadableBlobRegistry.h"

trunk/Source/WebCore/fileapi/WebKitBlobBuilder.cpp

@@ -38 +38 @@
 #include "HistogramSupport.h"
 #include "LineEnding.h"
+#include "ScriptCallStack.h"
 #include "ScriptExecutionContext.h"
 #include "TextEncoding.h"

trunk/Source/WebCore/html/HTMLTrackElement.cpp

@@ -35 +35 @@
 #include "Logging.h"
 #include "RuntimeEnabledFeatures.h"
+#include "ScriptCallStack.h"
 #include "ScriptEventListener.h"
 

trunk/Source/WebCore/loader/TextTrackLoader.cpp

@@ -36 +36 @@
 #include "Logging.h"
 #include "ResourceHandle.h"
+#include "ScriptCallStack.h"
 #include "SecurityOrigin.h"
 #include "SharedBuffer.h"

trunk/Source/WebCore/page/DOMSecurityPolicy.cpp

@@ -31 +31 @@
 #include "DOMStringList.h"
 #include "Frame.h"
+#include "ScriptCallStack.h"
 #include "ScriptExecutionContext.h"
 #include <wtf/text/TextPosition.h>