Changeset 126846 in webkit

Timestamp:

Aug 27, 2012, 11:33:34 PM (14 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK] Memory cache should be cleared in between test runs
​https://bugs.webkit.org/show_bug.cgi?id=95105

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a DumpRenderTreeSupportGtk helper method that clears the
memory cache when called.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::clearMemoryCache):

• WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Call the new DumpRenderTreeSupportGtk helper method after every test
to clear the memory cache.

• DumpRenderTree/gtk/DumpRenderTree.cpp:

(runTest):

Location:

trunk

Files:

• Source/WebKit/gtk/ChangeLog (modified) (1 diff)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (modified) (2 diffs)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (1 diff)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Memory cache should be cleared in between test runs
+        https://bugs.webkit.org/show_bug.cgi?id=95105
+
+        Reviewed by Martin Robinson.
+
+        Add a DumpRenderTreeSupportGtk helper method that clears the
+        memory cache when called.
+
+        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+        (DumpRenderTreeSupportGtk::clearMemoryCache):
+        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+        (DumpRenderTreeSupportGtk):
+
 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

@@ -51 +51 @@
 #include "JSNodeList.h"
 #include "JSValue.h"
+#include "MemoryCache.h"
 #include "MutationObserver.h"
 #include "NodeList.h"
@@ -868 +869 @@
         coreFrame->view()->resetTrackedRepaints();
 }
+
+void DumpRenderTreeSupportGtk::clearMemoryCache()
+{
+    memoryCache()->evictResources();
+}

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

@@ -131 +131 @@
     static void resetTrackedRepaints(WebKitWebFrame*);
 
+    static void clearMemoryCache();
+
 private:
     static bool s_drtRun;

trunk/Tools/ChangeLog

@@ +1 @@
+2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Memory cache should be cleared in between test runs
+        https://bugs.webkit.org/show_bug.cgi?id=95105
+
+        Reviewed by Martin Robinson.
+
+        Call the new DumpRenderTreeSupportGtk helper method after every test
+        to clear the memory cache.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (runTest):
+
 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -770 +770 @@
 
     WebCoreTestSupport::resetInternalsObject(webkit_web_frame_get_global_context(mainFrame));
+    DumpRenderTreeSupportGtk::clearMemoryCache();
 
     // A blank load seems to be necessary to reset state after certain tests.