Changeset 126851 in webkit

Timestamp:

Aug 28, 2012, 12:01:03 AM (14 years ago)

Author:

caseq@chromium.org

Message:

Web Inspector: persist the state of glue records to parents button of Timeline panel
​https://bugs.webkit.org/show_bug.cgi?id=95091

Reviewed by Vsevolod Vlasov.

Add a setting for "Glue records" button on the timeline, use it to persist the state of the button.

• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._createStatusBarItems.get this):
(WebInspector.TimelinePanel.prototype._createStatusBarItems):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelinePanel.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-27  Andrey Kosyakov  <caseq@chromium.org>
+
+        Web Inspector: persist the state of glue records to parents button of Timeline panel
+        https://bugs.webkit.org/show_bug.cgi?id=95091
+
+        Reviewed by Vsevolod Vlasov.
+
+        Add a setting for "Glue records" button on the timeline, use it to persist the state of the button.
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel):
+        (WebInspector.TimelinePanel.prototype._createStatusBarItems.get this):
+        (WebInspector.TimelinePanel.prototype._createStatusBarItems):
+
 2012-08-27  Taiju Tsuiki  <tzik@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/TimelinePanel.js

@@ -47 +47 @@
     this._presentationModel = new WebInspector.TimelinePresentationModel();
 
+    this._overviewModeSetting = WebInspector.settings.createSetting("timelineOverviewMode", WebInspector.TimelineOverviewPane.Mode.Events);
+    this._glueRecordsSetting = WebInspector.settings.createSetting("timelineGlueRecords", true);
+
     this._overviewPane = new WebInspector.TimelineOverviewPane(this._model);
     this._overviewPane.addEventListener(WebInspector.TimelineOverviewPane.Events.WindowChanged, this._scheduleRefresh.bind(this, false));
@@ -146 +149 @@
     this._presentationModel.addFilter(new WebInspector.TimelineCategoryFilter()); 
     this._presentationModel.addFilter(new WebInspector.TimelineIsLongFilter(this)); 
-
-    this._overviewModeSetting = WebInspector.settings.createSetting("timelineOverviewMode", WebInspector.TimelineOverviewPane.Mode.Events);
 }
 
@@ -236 +237 @@
 
         this._glueParentButton = new WebInspector.StatusBarButton(WebInspector.UIString("Glue asynchronous events to causes"), "glue-async-status-bar-item");
-        this._glueParentButton.toggled = true;
-        this._presentationModel.setGlueRecords(true);
+        this._glueParentButton.toggled = this._glueRecordsSetting.get();
+        this._presentationModel.setGlueRecords(this._glueParentButton.toggled);
         this._glueParentButton.addEventListener("click", this._glueParentButtonClicked, this);
         this._statusBarButtons.push(this._glueParentButton);
@@ -540 +541 @@
     _glueParentButtonClicked: function()
     {
-        this._glueParentButton.toggled = !this._glueParentButton.toggled;
-        this._presentationModel.setGlueRecords(this._glueParentButton.toggled);
+        var newValue = !this._glueParentButton.toggled;
+        this._glueParentButton.toggled = newValue;
+        this._presentationModel.setGlueRecords(newValue);
+        this._glueRecordsSetting.set(newValue);
         this._repopulateRecords();
     },