⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 126884 in webkit


Ignore:
Timestamp:
Aug 28, 2012, 8:46:51 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL] WebKit EFL updates view on HTTP 204 response
​https://bugs.webkit.org/show_bug.cgi?id=95199

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-28
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Ignore HTTP responses which have status code equal
to 204 (No Content).

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):

Source/WebKit2:

Ignore HTTP responses which have status code equal
to 204 (No Content).

  • UIProcess/API/efl/ewk_view_policy_client.cpp:

(decidePolicyForResponseCallback):

LayoutTests:

Unskip http/tests/navigation/response204.html now
that EFL port properly ignores responses with
HTTP status 204 (No content).

  • platform/efl-wk2/TestExpectations:
  • platform/efl/Skipped:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r126882 r126884  
     12012-08-28  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL] WebKit EFL updates view on HTTP 204 response
     4        https://bugs.webkit.org/show_bug.cgi?id=95199
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Unskip http/tests/navigation/response204.html now
     9        that EFL port properly ignores responses with
     10        HTTP status 204 (No content).
     11
     12        * platform/efl-wk2/TestExpectations:
     13        * platform/efl/Skipped:
     14
    1152012-08-28  János Badics  <jbadics@inf.u-szeged.hu>
    216

  • trunk/LayoutTests/platform/efl-wk2/TestExpectations

    r126866 r126884  
    139139
    140140// WebKitTestRunner needs an implementation for testRunner.queueLoad
    141 BUGWKEFL : fast/dom/navigation-type-back-forward.html = TEXT
    142 BUGWKEFL : fast/dom/navigation-type-navigate.html = TEXT
    143 BUGWKEFL : fast/dom/navigation-type-reload.html = TEXT
     141BUGWK42674 : fast/dom/navigation-type-back-forward.html = TEXT
     142BUGWK42674 : fast/dom/navigation-type-navigate.html = TEXT
     143BUGWK42674 : fast/dom/navigation-type-reload.html = TEXT
     144BUGWK42674 : http/tests/navigation/response204.html = TEXT
    144145
    145146// WebKitTestRunner needs an implementation for testRunner.titleTextDirection

  • trunk/LayoutTests/platform/efl/Skipped

    r126880 r126884  
    357357# https://bugs.webkit.org/show_bug.cgi?id=54251
    358358http/tests/multipart/invalid-image-data-standalone.html
    359 
    360 # HTTP 204 (No Content) should be ignored
    361 # https://bugs.webkit.org/show_bug.cgi?id=60206
    362 http/tests/navigation/response204.html
    363359
    364360# http/tests/multipart/stop-crash.html fails on GTK and Qt missing multipart/x-mixed-replace support in libsoup

  • trunk/Source/WebKit/efl/ChangeLog

    r126868 r126884  
     12012-08-28  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL] WebKit EFL updates view on HTTP 204 response
     4        https://bugs.webkit.org/show_bug.cgi?id=95199
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Ignore HTTP responses which have status code equal
     9        to 204 (No Content).
     10
     11        * WebCoreSupport/FrameLoaderClientEfl.cpp:
     12        (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
     13
    1142012-08-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
    215

  • trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp

    r125500 r126884  
    4646#include "FrameView.h"
    4747#include "HTMLFormElement.h"
     48#include "HTTPStatusCodes.h"
    4849#include "IntentRequest.h"
    4950#include "MIMETypeRegistry.h"
    … …  
    298299    }
    299300
     301    // Ignore responses with an HTTP status code of 204 (No Content)
     302    if (response.httpStatusCode() == HTTPNoContent) {
     303        callPolicyFunction(function, PolicyIgnore);
     304        return;
     305    }
     306
    300307    if (canShowMIMEType(response.mimeType()))
    301308        callPolicyFunction(function, PolicyUse);

  • trunk/Source/WebKit2/ChangeLog

    r126877 r126884  
     12012-08-28  Christophe Dumez  <christophe.dumez@intel.com>
     2
     3        [EFL] WebKit EFL updates view on HTTP 204 response
     4        https://bugs.webkit.org/show_bug.cgi?id=95199
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Ignore HTTP responses which have status code equal
     9        to 204 (No Content).
     10
     11        * UIProcess/API/efl/ewk_view_policy_client.cpp:
     12        (decidePolicyForResponseCallback):
     13
    1142012-08-28  Zeno Albisser  <zeno@webkit.org>
    215

  • trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client.cpp

    r122803 r126884  
    3232#include "ewk_view_policy_client_private.h"
    3333#include "ewk_view_private.h"
     34#include <WebCore/HTTPStatusCodes.h>
    3435#include <wtf/text/CString.h>
    3536
    … …  
    5960{
    6061    const ResourceResponse resourceResponse = toImpl(response)->resourceResponse();
     62
     63    // Ignore responses with an HTTP status code of 204 (No Content)
     64    if (resourceResponse.httpStatusCode() == HTTPNoContent) {
     65        WKFramePolicyListenerIgnore(listener);
     66        return;
     67    }
     68
    6169    // If the URL Response has "Content-Disposition: attachment;" header, then
    6270    // we should download it.
Note: See TracChangeset for help on using the changeset viewer.