Changeset 126891 in webkit

Timestamp:

Aug 28, 2012, 10:40:19 AM (14 years ago)

Author:

kov@webkit.org

Message:

[GTK] Does not regenerate CSS-related sources when configuration changes
​https://bugs.webkit.org/show_bug.cgi?id=94927

Reviewed by Eric Seidel.

In bug 94094 the gtk EWS consistently failed to build the patch. The
reason that happens is the .in files have not been touched, so the CSS
property names and value keywords sources are not regenerated. By
adding an explicit dependency on configure.ac and GNUmakefile.am the
problem is fixed (see bug 82465, attachment 160265).

• GNUmakefile.am: add explicit dependency from the CSS-related .in files

on configure.ac and WebCore's GNUmakefile.am

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• GNUmakefile.am (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-28  Gustavo Noronha Silva  <gns@gnome.org>
+
+        [GTK] Does not regenerate CSS-related sources when configuration changes
+        https://bugs.webkit.org/show_bug.cgi?id=94927
+
+        Reviewed by Eric Seidel.
+
+        In bug 94094 the gtk EWS consistently failed to build the patch. The
+        reason that happens is the .in files have not been touched, so the CSS
+        property names and value keywords sources are not regenerated. By
+        adding an explicit dependency on configure.ac and GNUmakefile.am the
+        problem is fixed (see bug 82465, attachment 160265).
+
+        * GNUmakefile.am: add explicit dependency from the CSS-related .in files
+        on configure.ac and WebCore's GNUmakefile.am
+
 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/GNUmakefile.am

@@ -802 +802 @@
 webcore_cppflags += $(foreach define,$(feature_defines),-D$(define))
 
+
+$(WEBCORE_CSS_PROPERTY_NAMES): $(srcdir)/configure.ac $(srcdir)/Source/WebCore/GNUmakefile.am
+
+$(WEBCORE_CSS_VALUE_KEYWORDS): $(srcdir)/configure.ac $(srcdir)/Source/WebCore/GNUmakefile.am
 
 DerivedSources/WebCore/CSSPropertyNames.cpp: DerivedSources/WebCore/CSSPropertyNames.h