Changeset 126905 in webkit

Timestamp:

Aug 28, 2012, 11:36:38 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
​https://bugs.webkit.org/show_bug.cgi?id=94700

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-08-28
Reviewed by Eric Seidel.

Interrupting download with a timeout would be a possible solution.
I imported the socket module and used the setdefaulttimeout() method.
Fixing it is important, because EWS bots need to be restarted regularly
because of this bug.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._get_browser):
(Bugzilla.setdefaulttimeout):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla/bugzilla.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
+
+        [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
+        https://bugs.webkit.org/show_bug.cgi?id=94700
+
+        Reviewed by Eric Seidel.
+
+        Interrupting download with a timeout would be a possible solution.
+        I imported the socket module and used the setdefaulttimeout() method.
+        Fixing it is important, because EWS bots need to be restarted regularly
+        because of this bug.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        (Bugzilla._get_browser):
+        (Bugzilla.setdefaulttimeout):
+
 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
 

trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py

@@ -34 +34 @@
 import re
 import StringIO
+import socket
 import urllib
 
@@ -280 +281 @@
     def _get_browser(self):
         if not self._browser:
+            self.setdefaulttimeout(600)
             from webkitpy.thirdparty.autoinstalled.mechanize import Browser
             self._browser = Browser()
@@ -290 +292 @@
 
     browser = property(_get_browser, _set_browser)
+
+    def setdefaulttimeout(self, value):
+        socket.setdefaulttimeout(value)
 
     def fetch_user(self, user_id):