Changeset 126906 in webkit

Timestamp:

Aug 28, 2012, 11:42:07 AM (14 years ago)

Author:

ggaren@apple.com

Message:

GCC warning in JSActivation is causing Mac EWS errors
​https://bugs.webkit.org/show_bug.cgi?id=95103

Reviewed by Sam Weinig.

Try to fix a strict aliasing violation by using bitwise_cast. The
union in the cast should signal to the compiler that aliasing between
types is happening.

• runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildren):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSActivation.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-08-28  Geoffrey Garen  <ggaren@apple.com>
+
+        GCC warning in JSActivation is causing Mac EWS errors
+        https://bugs.webkit.org/show_bug.cgi?id=95103
+
+        Reviewed by Sam Weinig.
+
+        Try to fix a strict aliasing violation by using bitwise_cast. The
+        union in the cast should signal to the compiler that aliasing between
+        types is happening.
+
+        * runtime/JSActivation.cpp:
+        (JSC::JSActivation::visitChildren):
+
 2012-08-28  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

@@ -72 +72 @@
         return;
 
-    visitor.copyAndAppend(reinterpret_cast<void**>(&registerArray), thisObject->registerArraySizeInBytes(), reinterpret_cast<JSValue*>(registerArray), thisObject->registerArraySize());
+    visitor.copyAndAppend(bitwise_cast<void**>(&registerArray), thisObject->registerArraySizeInBytes(), reinterpret_cast<JSValue*>(registerArray), thisObject->registerArraySize());
     thisObject->m_registerArray.set(registerArray, StorageBarrier::Unchecked);
     thisObject->m_registers = registerArray + thisObject->registerOffset();