Changeset 126921 in webkit

Timestamp:

Aug 28, 2012, 1:19:16 PM (14 years ago)

Author:

jer.noble@apple.com

Message:

Crash in WebCore::logPluginRequest + 183
​https://bugs.webkit.org/show_bug.cgi?id=95218

Reviewed by Oliver Hunt.

Crash is within findPluginMIMETypeFromURL, caused by a null-dereference of
page()->pluginData(). Add a null-check and return an empty string.

• loader/SubframeLoader.cpp:

(WebCore::findPluginMIMETypeFromURL):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/SubframeLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-08-28  Jer Noble  <jer.noble@apple.com>
+
+        Crash in WebCore::logPluginRequest + 183
+        https://bugs.webkit.org/show_bug.cgi?id=95218
+
+        Reviewed by Oliver Hunt.
+
+        Crash is within findPluginMIMETypeFromURL, caused by a null-dereference of 
+        page()->pluginData().  Add a null-check and return an empty string.
+
+        * loader/SubframeLoader.cpp:
+        (WebCore::findPluginMIMETypeFromURL):
+
 2012-08-28  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/loader/SubframeLoader.cpp

@@ -172 +172 @@
 
     PluginData* pluginData = page->pluginData();
+    if (!pluginData)
+        return String();
+
     for (size_t i = 0; i < pluginData->mimes().size(); ++i) {
         const MimeClassInfo& mimeClassInfo = pluginData->mimes()[i];