Changeset 126924 in webkit

Timestamp:

Aug 28, 2012, 1:44:58 PM (14 years ago)

Author:

fpizlo@apple.com

Message:

LLInt should not rely on ordering of global labels
​https://bugs.webkit.org/show_bug.cgi?id=95221

Reviewed by Oliver Hunt.

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• llint/LowLevelInterpreter.asm (modified) (9 diffs)
• llint/LowLevelInterpreter32_64.asm (modified) (1 diff)
• llint/LowLevelInterpreter64.asm (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-08-28  Filip Pizlo  <fpizlo@apple.com>
+
+        LLInt should not rely on ordering of global labels
+        https://bugs.webkit.org/show_bug.cgi?id=95221
+
+        Reviewed by Oliver Hunt.
+
+        * llint/LowLevelInterpreter.asm:
+        * llint/LowLevelInterpreter32_64.asm:
+        * llint/LowLevelInterpreter64.asm:
+
 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm

@@ -533 +533 @@
 
 _llint_op_loop_if_true:
-    nop
-_llint_op_jtrue:
     traceExecution()
     jumpTrueOrFalse(
@@ -541 +539 @@
 
 
+_llint_op_jtrue:
+    traceExecution()
+    jumpTrueOrFalse(
+        macro (value, target) btinz value, target end,
+        _llint_slow_path_jtrue)
+
+
 _llint_op_loop_if_false:
-    nop
-_llint_op_jfalse:
     traceExecution()
     jumpTrueOrFalse(
@@ -550 +553 @@
 
 
+_llint_op_jfalse:
+    traceExecution()
+    jumpTrueOrFalse(
+        macro (value, target) btiz value, target end,
+        _llint_slow_path_jfalse)
+
+
 _llint_op_loop_if_less:
-    nop
-_llint_op_jless:
     traceExecution()
     compare(
@@ -560 +568 @@
 
 
+_llint_op_jless:
+    traceExecution()
+    compare(
+        macro (left, right, target) bilt left, right, target end,
+        macro (left, right, target) bdlt left, right, target end,
+        _llint_slow_path_jless)
+
+
 _llint_op_jnless:
     traceExecution()
@@ -569 +585 @@
 
 _llint_op_loop_if_greater:
-    nop
-_llint_op_jgreater:
     traceExecution()
     compare(
@@ -578 +592 @@
 
 
+_llint_op_jgreater:
+    traceExecution()
+    compare(
+        macro (left, right, target) bigt left, right, target end,
+        macro (left, right, target) bdgt left, right, target end,
+        _llint_slow_path_jgreater)
+
+
 _llint_op_jngreater:
     traceExecution()
@@ -587 +609 @@
 
 _llint_op_loop_if_lesseq:
-    nop
-_llint_op_jlesseq:
     traceExecution()
     compare(
@@ -596 +616 @@
 
 
+_llint_op_jlesseq:
+    traceExecution()
+    compare(
+        macro (left, right, target) bilteq left, right, target end,
+        macro (left, right, target) bdlteq left, right, target end,
+        _llint_slow_path_jlesseq)
+
+
 _llint_op_jnlesseq:
     traceExecution()
@@ -605 +633 @@
 
 _llint_op_loop_if_greatereq:
-    nop
+    traceExecution()
+    compare(
+        macro (left, right, target) bigteq left, right, target end,
+        macro (left, right, target) bdgteq left, right, target end,
+        _llint_slow_path_jgreatereq)
+
+
 _llint_op_jgreatereq:
     traceExecution()

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm

@@ -1398 +1398 @@
 
 _llint_op_loop:
-    nop
+    traceExecution()
+    dispatchBranch(4[PC])
+
+
 _llint_op_jmp:
     traceExecution()

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm

@@ -1235 +1235 @@
 
 _llint_op_loop:
-    nop
+    traceExecution()
+    dispatchInt(8[PB, PC, 8])
+
+
 _llint_op_jmp:
     traceExecution()