Changeset 127222 in webkit

Timestamp:

Aug 30, 2012, 6:15:12 PM (14 years ago)

Author:

fpizlo@apple.com

Message:

ASSERTION FAILURE in JSC::JSGlobalData::float32ArrayDescriptor when running fast/js/dfg-float64array.html
​https://bugs.webkit.org/show_bug.cgi?id=95398

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Trying to get the build failure to be a bit more informative.

• runtime/JSGlobalData.h:

(JSGlobalData):

LayoutTests:

Temporarily unskipping tests to figure out what is going.

• platform/mac-wk2/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk2/Skipped (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSGlobalData.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-08-30  Filip Pizlo  <fpizlo@apple.com>
+
+        ASSERTION FAILURE in JSC::JSGlobalData::float32ArrayDescriptor when running fast/js/dfg-float64array.html
+        https://bugs.webkit.org/show_bug.cgi?id=95398
+
+        Reviewed by Mark Hahnenberg.
+
+        Temporarily unskipping tests to figure out what is going.
+
+        * platform/mac-wk2/Skipped:
+
 2012-08-30  Roger Fong  <roger_fong@apple.com>
 

trunk/LayoutTests/platform/mac-wk2/Skipped

@@ -376 +376 @@
 sputnik/Unicode/Unicode_218/S7.6_A5.2_T1.html
 
-# Asserts under JSC::DFG::SpeculativeJIT::typedArrayDescriptor
-# https://bugs.webkit.org/show_bug.cgi?id=95398
-fast/js/dfg-int32array.html
-fast/js/dfg-float32array.html
-fast/js/dfg-uint8clampedarray.html
-fast/js/dfg-poison-fuzz.html
-fast/js/dfg-float64array.html
-fast/js/dfg-int32array-overflow-values.html
-fast/js/dfg-inline-function-dot-caller.html
-
 ### END OF (3) Unclassified failures
 ########################################

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-08-30  Filip Pizlo  <fpizlo@apple.com>
+
+        ASSERTION FAILURE in JSC::JSGlobalData::float32ArrayDescriptor when running fast/js/dfg-float64array.html
+        https://bugs.webkit.org/show_bug.cgi?id=95398
+
+        Reviewed by Mark Hahnenberg.
+
+        Trying to get the build failure to be a bit more informative.
+
+        * runtime/JSGlobalData.h:
+        (JSGlobalData):
+
 2012-08-30  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSGlobalData.h

@@ -421 +421 @@
             ASSERT(!m_##type##ArrayDescriptor.m_classInfo || m_##type##ArrayDescriptor.m_classInfo == descriptor.m_classInfo); \
             m_##type##ArrayDescriptor = descriptor; \
+            ASSERT(m_##type##ArrayDescriptor.m_classInfo); \
         } \
         const TypedArrayDescriptor& type##ArrayDescriptor() const { ASSERT(m_##type##ArrayDescriptor.m_classInfo); return m_##type##ArrayDescriptor; }