Changeset 128662 in webkit

Timestamp:

Sep 14, 2012, 3:48:12 PM (13 years ago)

Author:

Stephanie Lewis

Message:

mac-future ignores previous platform TestExpectations.
​https://bugs.webkit.org/show_bug.cgi?id=96718.

Reviewed by Dirk Pranke.

TestExpectations match an expectation's configuraton against a list of configurations that are
valid for that port. That list does not contain mac-future so none of the expectations can be
applied.

• Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/apple.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-09-13  Stephanie Lewis  <slewis@apple.com>
+
+        mac-future ignores previous platform TestExpectations.
+        https://bugs.webkit.org/show_bug.cgi?id=96718.
+
+        Reviewed by Dirk Pranke.
+
+        TestExpectations match an expectation's configuraton against a list of configurations that are 
+        valid for that port.  That list does not contain mac-future so none of the expectations can be
+        applied.
+
+        * Scripts/webkitpy/layout_tests/port/apple.py:
+        (ApplePort._generate_all_test_configurations):
+
 2012-09-14  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py

@@ -93 +93 @@
     def _generate_all_test_configurations(self):
         configurations = []
-        for port_name in self.VERSION_FALLBACK_ORDER:
+        allowed_port_names = self.VERSION_FALLBACK_ORDER + [self.operating_system() + "-future"]
+        for port_name in allowed_port_names:
             for build_type in self.ALL_BUILD_TYPES:
                 for architecture in self.ARCHITECTURES: