Changeset 130062 in webkit

Timestamp:

Oct 1, 2012, 12:07:57 PM (13 years ago)

Author:

jochen@chromium.org

Message:

[chromium] ASSERT that the embedder has set a default locale
​https://bugs.webkit.org/show_bug.cgi?id=98001

Reviewed by Adam Barth.

The callsites assume that the default language is always defined, e.g.
Document::getCachedLocalizer. Add an ASSERT() statement so an embedder
doesn't have to guess what they did wrong.

• platform/chromium/LanguageChromium.cpp:

(WebCore::platformLanguage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/chromium/LanguageChromium.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-01  Jochen Eisinger  <jochen@chromium.org>
+
+        [chromium] ASSERT that the embedder has set a default locale
+        https://bugs.webkit.org/show_bug.cgi?id=98001
+
+        Reviewed by Adam Barth.
+
+        The callsites assume that the default language is always defined, e.g.
+        Document::getCachedLocalizer. Add an ASSERT() statement so an embedder
+        doesn't have to guess what they did wrong.
+
+        * platform/chromium/LanguageChromium.cpp:
+        (WebCore::platformLanguage):
+
 2012-10-01  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Source/WebCore/platform/chromium/LanguageChromium.cpp

@@ -41 +41 @@
 {
     DEFINE_STATIC_LOCAL(String, computedDefaultLanguage, ());
-    if (computedDefaultLanguage.isEmpty())
+    if (computedDefaultLanguage.isEmpty()) {
         computedDefaultLanguage.append(WebKit::Platform::current()->defaultLocale());
+        ASSERT(!computedDefaultLanguage.isEmpty());
+    }
     return computedDefaultLanguage;
 }