Changeset 130306 in webkit

Timestamp:

Oct 3, 2012, 11:15:09 AM (13 years ago)

Author:

ojan@chromium.org

Message:

Get rid of warning about non-existant platform name when loading garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=98282

Reviewed by Adam Barth.

If you loaded without a platform query parameter we'd return "null" as the platform name
instead of null.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js

@@ -439 +439 @@
 base.getURLParameter = function(name)
 {
-    return decodeURI(
-        (RegExp(name + '=' + '(.+?)(&|$)').exec(location.search)||[,null])[1]
-    );
-}
-
+    var match = RegExp(name + '=' + '(.+?)(&|$)').exec(location.search);
+    if (!match)
+        return null;
+    return decodeURI(match[1])
+}
 
 base.underscoredBuilderName = function(builderName)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js

@@ -461 +461 @@
     time.setDate(time.getDate() - 998);
     equals(base.relativizeTime(time), "1000 days ago");
-})
+});
+
+test("getURLParameter", 1, function() {
+    ok(!base.getURLParameter('non-existant'));
+});
 
 })();

trunk/Tools/ChangeLog

@@ +1 @@
+2012-10-03  Ojan Vafai  <ojan@chromium.org>
+
+        Get rid of warning about non-existant platform name when loading garden-o-matic
+        https://bugs.webkit.org/show_bug.cgi?id=98282
+
+        Reviewed by Adam Barth.
+
+        If you loaded without a platform query parameter we'd return "null" as the platform name
+        instead of null.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
+
 2012-10-03  Balazs Kelemen  <kbalazs@webkit.org>