Changeset 130311 in webkit

Timestamp:

Oct 3, 2012, 12:17:18 PM (13 years ago)

Author:

benjamin@webkit.org

Message:

Element::computeInheritedLanguage: evaluate the while() condition after fetching the string
​https://bugs.webkit.org/show_bug.cgi?id=98220

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-10-03
Reviewed by Andreas Kling.

• dom/Element.cpp:

(WebCore::Element::computeInheritedLanguage):
The condition is never false on the first execution. Move the condition to the
end of the loop for fun and profit.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
+
+        Element::computeInheritedLanguage: evaluate the while() condition after fetching the string
+        https://bugs.webkit.org/show_bug.cgi?id=98220
+
+        Reviewed by Andreas Kling.
+
+        * dom/Element.cpp:
+        (WebCore::Element::computeInheritedLanguage):
+        The condition is never false on the first execution. Move the condition to the
+        end of the loop for fun and profit.
+
 2012-10-03  Hans Wennborg  <hans@chromium.org>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -1757 +1757 @@
     AtomicString value;
     // The language property is inherited, so we iterate over the parents to find the first language.
-    while (n && value.isNull()) {
+    do {
         if (n->isElementNode()) {
             // Spec: xml:lang takes precedence -- http://www.w3.org/TR/xhtml1/#C_7
@@ -1769 +1769 @@
 
         n = n->parentNode();
-    }
+    } while (n && value.isNull());
 
     return value;