Changeset 130355 in webkit


Ignore:
Timestamp:
Oct 3, 2012, 7:17:34 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Chromium needs support for border radius clipping
​https://bugs.webkit.org/show_bug.cgi?id=69866

Patch by Douglas Stockwell <​dstockwell@chromium.org> on 2012-10-03
Reviewed by Stephen White.

Source/WebCore:

Changes to make this suitably efficient have already landed upstream in skia:
​http://code.google.com/p/skia/source/detail?r=2924

Covered by existing tests.

  • rendering/RenderLayer.cpp:

LayoutTests:

  • platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png:
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-styling-strict-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium/TestExpectations:
Location:
trunk
Files:
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r130346 r130355  
     12012-10-03  Douglas Stockwell  <dstockwell@chromium.org>
     2
     3        Chromium needs support for border radius clipping
     4        https://bugs.webkit.org/show_bug.cgi?id=69866
     5
     6        Reviewed by Stephen White.
     7
     8        * platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png:
     9        * platform/chromium-linux/fast/clip/overflow-border-radius-fixed-position-expected.png:
     10        * platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png:
     11        * platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
     12        * platform/chromium-linux/media/audio-controls-rendering-expected.png:
     13        * platform/chromium-linux/media/audio-repaint-expected.png:
     14        * platform/chromium-linux/media/controls-after-reload-expected.png:
     15        * platform/chromium-linux/media/controls-strict-expected.png:
     16        * platform/chromium-linux/media/controls-styling-expected.png:
     17        * platform/chromium-linux/media/controls-styling-strict-expected.png:
     18        * platform/chromium-linux/media/controls-without-preload-expected.png:
     19        * platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
     20        * platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
     21        * platform/chromium-linux/media/video-controls-rendering-expected.png:
     22        * platform/chromium-linux/media/video-display-toggle-expected.png:
     23        * platform/chromium-linux/media/video-no-audio-expected.png:
     24        * platform/chromium-linux/media/video-playing-and-pause-expected.png:
     25        * platform/chromium-linux/media/video-zoom-controls-expected.png:
     26        * platform/chromium/TestExpectations:
     27
    1282012-10-03  Tony Chang  <tony@chromium.org>
    229

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r130314 r130355  
    25242524webkit.org/b/95365 fast/loader/reload-zero-byte-plugin.html
    25252525
    2526 # Performance issues with border radius clipping on Chromium not yet resolved
    2527 crbug.com/97716 fast/clip/overflow-border-radius-composited.html [ ImageOnlyFailure ]
    2528 # Consistently failing as of about r95590
    2529 crbug.com/97716 fast/clip/overflow-border-radius-fixed-position.html [ ImageOnlyFailure ]
    2530 crbug.com/97716 fast/clip/overflow-border-radius-transformed.html [ ImageOnlyFailure ]
    2531 crbug.com/97716 fast/clip/overflow-border-radius-combinations.html [ ImageOnlyFailure ]
     2526webkit.org/b/68196 fast/clip/overflow-border-radius-composited.html [ ImageOnlyFailure ]
     2527
     2528# Needs rebaseline
     2529webkit.org/b/69866 [ Android Mac Win ] fast/clip/overflow-border-radius-combinations.html [ ImageOnlyFailure ]
     2530webkit.org/b/69866 [ Android Mac Win ] fast/clip/overflow-border-radius-fixed-position.html [ ImageOnlyFailure ]
     2531webkit.org/b/69866 [ Android Mac Win ] fast/clip/overflow-border-radius-transformed.html [ ImageOnlyFailure ]
     2532webkit.org/b/69866 [ Android Mac Win ] http/tests/media/video-buffered-range-contains-currentTime.html [ ImageOnlyFailure ]
     2533webkit.org/b/69866 [ Android Mac Win ] media/audio-controls-rendering.html [ ImageOnlyFailure ]
     2534webkit.org/b/69866 [ Android Mac Win ] media/audio-repaint.html [ ImageOnlyFailure ]
     2535webkit.org/b/69866 [ Android Mac Win ] media/controls-after-reload.html [ ImageOnlyFailure ]
     2536webkit.org/b/69866 [ Android Mac Win ] media/controls-strict.html [ ImageOnlyFailure ]
     2537webkit.org/b/69866 [ Android Mac Win ] media/controls-styling-strict.html [ ImageOnlyFailure ]
     2538webkit.org/b/69866 [ Android Mac Win ] media/controls-styling.html [ ImageOnlyFailure ]
     2539webkit.org/b/69866 [ Android Mac Win ] media/controls-without-preload.html [ ImageOnlyFailure ]
     2540webkit.org/b/69866 [ Android Mac Win ] media/track/track-cue-rendering-horizontal.html [ ImageOnlyFailure ]
     2541webkit.org/b/69866 [ Android Mac Win ] media/track/track-cue-rendering-vertical.html [ ImageOnlyFailure ]
     2542webkit.org/b/69866 [ Android Mac Win ] media/video-controls-rendering.html [ ImageOnlyFailure ]
     2543webkit.org/b/69866 [ Android Mac Win ] media/video-display-toggle.html [ ImageOnlyFailure ]
     2544webkit.org/b/69866 [ Android Mac Win ] media/video-no-audio.html [ ImageOnlyFailure ]
     2545webkit.org/b/69866 [ Android Mac Win ] media/video-playing-and-pause.html [ ImageOnlyFailure ]
     2546webkit.org/b/69866 [ Android Mac Win ] media/video-zoom-controls.html [ ImageOnlyFailure ]
    25322547
    25332548# Caused by r92618

  • trunk/Source/WebCore/ChangeLog

    r130354 r130355  
     12012-10-03  Douglas Stockwell  <dstockwell@chromium.org>
     2
     3        Chromium needs support for border radius clipping
     4        https://bugs.webkit.org/show_bug.cgi?id=69866
     5
     6        Reviewed by Stephen White.
     7
     8        Changes to make this suitably efficient have already landed upstream in skia:
     9        http://code.google.com/p/skia/source/detail?r=2924
     10
     11        Covered by existing tests.
     12
     13        * rendering/RenderLayer.cpp:
     14
    1152012-10-03  Benjamin Poulain  <bpoulain@apple.com>
    216

  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r130331 r130355  
    110110#endif
    111111
    112 #if PLATFORM(CHROMIUM) || PLATFORM(BLACKBERRY)
    113 // FIXME: border radius clipping triggers too-slow path on Chromium
    114 // https://bugs.webkit.org/show_bug.cgi?id=69866
     112#if PLATFORM(BLACKBERRY)
    115113#define DISABLE_ROUNDED_CORNER_CLIPPING
    116114#endif
Note: See TracChangeset for help on using the changeset viewer.