Changeset 130534 in webkit

Timestamp:

Oct 5, 2012, 11:34:13 AM (13 years ago)

Author:

jer.noble@apple.com

Message:

No autorelease pool in place, causing buildup of autoreleased objects.
​https://bugs.webkit.org/show_bug.cgi?id=98522
<rdar://problem/11647950>

Reviewed by Alexey Proskuryakov.

Wrap each timer callback in an AutodrainPool, ensuring an autorelease
pool is present during calls from C/C++ into ObjC.

• platform/cf/RunLoopTimerCF.cpp:

(WebCore::timerFired):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/cf/RunLoopTimerCF.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-05  Jer Noble  <jer.noble@apple.com>
+
+        No autorelease pool in place, causing buildup of autoreleased objects.
+        https://bugs.webkit.org/show_bug.cgi?id=98522
+        <rdar://problem/11647950>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Wrap each timer callback in an AutodrainPool, ensuring an autorelease
+        pool is present during calls from C/C++ into ObjC.
+
+        * platform/cf/RunLoopTimerCF.cpp:
+        (WebCore::timerFired):
+
 2012-10-05  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/platform/cf/RunLoopTimerCF.cpp

@@ -32 +32 @@
 
 #include "RunLoopTimer.h"
+#include "AutodrainedPool.h"
 
 namespace WebCore {
@@ -42 +43 @@
 static void timerFired(CFRunLoopTimerRef, void* context)
 {
+    // CFRunLoopTimer does not create an NSAutoreleasePool, like NSTimer does. This can lead to
+    // autoreleased objects being pushed into NSAutoreleasePools underneath the run loop, which
+    // are very infrequently drained. Create a new autorelease pool here to give autoreleased objects
+    // a place to collect.
+    AutodrainedPool pool;
     RunLoopTimerBase* timer = static_cast<RunLoopTimerBase*>(context);
     timer->fired();