Changeset 130587 in webkit

Timestamp:

Oct 6, 2012, 11:51:05 AM (14 years ago)

Author:

ggaren@apple.com

Message:

If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive
​https://bugs.webkit.org/show_bug.cgi?id=88834

Reviewed by Gavin Barraclough.

Follow-up patch to address some comments by Darin Adler.

• bindings/js/JSNodeCustom.h:

(WebCore::willCreatePossiblyOrphanedTreeByRemoval): Save some space by
collapsing comment lines. Use Node::hasChildNodes() for brevity.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSNodeCustom.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-06  Geoffrey Garen  <ggaren@apple.com>
+
+        If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive
+        https://bugs.webkit.org/show_bug.cgi?id=88834
+
+        Reviewed by Gavin Barraclough.
+
+        Follow-up patch to address some comments by Darin Adler.
+
+        * bindings/js/JSNodeCustom.h:
+        (WebCore::willCreatePossiblyOrphanedTreeByRemoval): Save some space by
+        collapsing comment lines. Use Node::hasChildNodes() for brevity.
+
 2012-10-06  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebCore/bindings/js/JSNodeCustom.h

@@ -73 +73 @@
 // root. In the JavaScript DOM, a node tree survives as long as there is a
 // reference to any node in the tree. To model the JavaScript DOM on top of
-// the C++ DOM, we ensure that the root of every tree has a JavaScript
-// wrapper.
+// the C++ DOM, we ensure that the root of every tree has a JavaScript wrapper.
 inline void willCreatePossiblyOrphanedTreeByRemoval(Node* root)
 {
@@ -80 +79 @@
         return;
 
-    if (!root->isContainerNode())
-        return;
-
-    if (!toContainerNode(root)->hasChildNodes())
+    if (!root->hasChildNodes())
         return;