Changeset 130646 in webkit

Timestamp:

Oct 8, 2012, 9:33:32 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Add support for window.create in Minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=98649

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Calling window.create() from JavaScript now creates a
new window in Minibrowser, as directed.

• MiniBrowser/efl/main.c:

(on_new_window):
(window_create):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/efl/main.c (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][WK2] Add support for window.create in Minibrowser
+        https://bugs.webkit.org/show_bug.cgi?id=98649
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Calling window.create() from JavaScript now creates a
+        new window in Minibrowser, as directed.
+
+        * MiniBrowser/efl/main.c:
+        (on_new_window):
+        (window_create):
+
 2012-10-08  Andreas Kling  <kling@webkit.org>
 

trunk/Tools/MiniBrowser/efl/main.c

@@ -221 +221 @@
 
 static void
+on_new_window(void *user_data, Evas_Object *webview, void *event_info)
+{
+    Evas_Object **new_view = (Evas_Object **)event_info;
+    Browser_Window *window = window_create(NULL, EINA_FALSE);
+    *new_view = window->webview;
+    windows = eina_list_append(windows, window);
+}
+
+static void
 on_progress(void *user_data, Evas_Object *webview, void *event_info)
 {
@@ -329 +338 @@
     ewk_settings_file_access_from_file_urls_allowed_set(settings, EINA_TRUE);
 
+    evas_object_smart_callback_add(window->webview, "create,window", on_new_window, window);
     evas_object_smart_callback_add(window->webview, "download,failed", on_download_failed, window);
     evas_object_smart_callback_add(window->webview, "download,finished", on_download_finished, window);
@@ -348 +358 @@
     window->url_bar = url_bar_add(window->webview, DEFAULT_WIDTH);
 
-    ewk_view_url_set(window->webview, url);
+    if (url)
+        ewk_view_url_set(window->webview, url);
 
     return window;