Changeset 130652 in webkit

Timestamp:

Oct 8, 2012, 10:13:48 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
​https://bugs.webkit.org/show_bug.cgi?id=98655

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Kenneth Rohde Christiansen.

Use "Ctrl+n" shortcut instead of "F9" to open a new window in
MiniBrowser and EWebLauncher. This is the shortcut that is
commonly used for this action.

• EWebLauncher/main.c:

(on_key_down):

• MiniBrowser/efl/main.c:

(on_key_down):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• EWebLauncher/main.c (modified) (1 diff)
• MiniBrowser/efl/main.c (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
+        https://bugs.webkit.org/show_bug.cgi?id=98655
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Use "Ctrl+n" shortcut instead of "F9" to open a new window in
+        MiniBrowser and EWebLauncher. This is the shortcut that is
+        commonly used for this action.
+
+        * EWebLauncher/main.c:
+        (on_key_down):
+        * MiniBrowser/efl/main.c:
+        (on_key_down):
+
 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
 

trunk/Tools/EWebLauncher/main.c

@@ -577 +577 @@
         if (currentZoomLevel < MAX_ZOOM_LEVEL && zoom_level_set(obj, currentZoomLevel + 1))
             currentZoomLevel++;
-    } else if (!strcmp(ev->key, "F9")) {
-        info("Create new window (F9) was pressed.\n");
+    } else if (!strcmp(ev->key, "n") && ctrlPressed) {
+        info("Create new window (Ctrl+n) was pressed.\n");
         browserCreate("http://www.google.com", app->userArgs);
     } else if (!strcmp(ev->key, "g") && ctrlPressed ) {

trunk/Tools/MiniBrowser/efl/main.c

@@ -148 +148 @@
     };
     static int currentEncoding = -1;
+    Eina_Bool ctrlPressed = evas_key_modifier_is_set(evas_key_modifier_get(e), "Control");
+
     if (!strcmp(ev->key, "F1")) {
         info("Back (F1) was pressed\n");
@@ -166 +168 @@
         info("Stop (F6) was pressed, stop loading.\n");
         ewk_view_stop(obj);
-    } else if (!strcmp(ev->key, "F9")) {
-        info("Create new window (F9) was pressed.\n");
+    } else if (!strcmp(ev->key, "n") && ctrlPressed) {
+        info("Create new window (Ctrl+n) was pressed.\n");
         Browser_Window *window = window_create(DEFAULT_URL, EINA_FALSE);
         windows = eina_list_append(windows, window);