Changeset 130677 in webkit

Timestamp:

Oct 8, 2012, 1:22:42 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing
​https://bugs.webkit.org/show_bug.cgi?id=98663

Patch by Christophe Dumez <Christophe Dumez> on 2012-10-08
Reviewed by Laszlo Gombos.

EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test was
failing because the elements of a list were checked in a given
order but the list was not sorted beforehand.

• UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(sortHostNames):
(TEST_F):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL][WK2] EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test is failing
+        https://bugs.webkit.org/show_bug.cgi?id=98663
+
+        Reviewed by Laszlo Gombos.
+
+        EWK2UnitTestBase.ewk_cookie_manager_accept_policy unit test was
+        failing because the elements of a list were checked in a given
+        order but the list was not sorted beforehand.
+
+        * UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
+        (sortHostNames):
+        (TEST_F):
+
 2012-10-08  Jinwoo Song  <jinwoo7.song@samsung.com>
 

trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp

@@ -117 +117 @@
 }
 
+static int compareHostNames(const void* hostName1, const void* hostName2)
+{
+    return strcmp(static_cast<const char*>(hostName1), static_cast<const char*>(hostName2));
+}
+
 TEST_F(EWK2UnitTestBase, ewk_cookie_manager_accept_policy)
 {
@@ -142 +147 @@
     hostnames = getHostnamesWithCookies(cookieManager);
     ASSERT_EQ(2, eina_list_count(hostnames));
+    hostnames = eina_list_sort(hostnames, eina_list_count(hostnames), compareHostNames);
     ASSERT_STREQ(FIRST_PARTY_DOMAIN, static_cast<char*>(eina_list_nth(hostnames, 0)));
     ASSERT_STREQ(THIRD_PARTY_DOMAIN, static_cast<char*>(eina_list_nth(hostnames, 1)));