Changeset 130682 in webkit

Timestamp:

Oct 8, 2012, 1:54:48 PM (14 years ago)

Author:

zandobersek@gmail.com

Message:

GTK port should warn if bug modifier is missing in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=98678

Reviewed by Dirk Pranke.

Tools:

Reimplement the warn_if_bug_missing_in_test_expectations method in
GtkPort, returning True for producing a warning in such cases.

• Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.warn_if_bug_missing_in_test_expectations):

LayoutTests:

Add generic Bug(GTK) modifiers for two test expectations.

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitpy/layout_tests/port/gtk.py (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-10-08  Zan Dobersek  <zandobersek@gmail.com>
+
+        GTK port should warn if bug modifier is missing in TestExpectations
+        https://bugs.webkit.org/show_bug.cgi?id=98678
+
+        Reviewed by Dirk Pranke.
+
+        Add generic Bug(GTK) modifiers for two test expectations.
+
+        * platform/gtk/TestExpectations:
+
 2012-10-08  Dirk Pranke  <dpranke@chromium.org>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1316 +1316 @@
 webkit.org/b/94083 media/video-controls-fullscreen-volume.html [ Skip ]
 
-fast/forms/date-multiple-fields
+Bug(GTK) fast/forms/date-multiple-fields [ Skip ]
 webkit.org/b/97299 fast/forms/month-multiple-fields
 webkit.org/b/94186 fast/forms/time-multiple-fields
@@ -1366 +1366 @@
 
 # Missing support in DRT for Geolocation's Coordinate attributes.
-fast/dom/Geolocation/coordinates-interface-attributes.html [ Failure ]
+Bug(GTK) fast/dom/Geolocation/coordinates-interface-attributes.html [ Failure ]
 
 webkit.org/b/98585 fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html [ ImageOnlyFailure ]

trunk/Tools/ChangeLog

@@ +1 @@
+2012-10-08  Zan Dobersek  <zandobersek@gmail.com>
+
+        GTK port should warn if bug modifier is missing in TestExpectations
+        https://bugs.webkit.org/show_bug.cgi?id=98678
+
+        Reviewed by Dirk Pranke.
+
+        Reimplement the warn_if_bug_missing_in_test_expectations method in
+        GtkPort, returning True for producing a warning in such cases.
+
+        * Scripts/webkitpy/layout_tests/port/gtk.py:
+        (GtkPort.warn_if_bug_missing_in_test_expectations):
+
 2012-10-08  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py

@@ -41 +41 @@
     def expectations_files(self):
         return [self._filesystem.join(self._webkit_baseline_path(d), 'TestExpectations') for d in self._skipped_file_search_paths()]
+
+    def warn_if_bug_missing_in_test_expectations(self):
+        return True
 
     def _port_flag_for_scripts(self):