Changeset 130789 in webkit

Timestamp:

Oct 9, 2012, 12:16:22 PM (13 years ago)

Author:

Martin Robinson

Message:

Fix the order of the statements in my previous build fix.

Reviewed by Gustavo Noronha Silva.

My previous build build fix for ResourceHandleSoup ordered the assignment
of the local ResourceHandleInternal incorrectly. Instead of being before
both assertions, it should be interspersed among them.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupMessageForHandleAndRequest):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/ResourceHandleSoup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-08  Martin Robinson  <mrobinson@igalia.com>
+
+        Fix the order of the statements in my previous build fix.
+
+        Reviewed by Gustavo Noronha Silva.
+
+        My previous build build fix for ResourceHandleSoup ordered the assignment
+        of the local ResourceHandleInternal incorrectly. Instead of being before
+        both assertions, it should be interspersed among them.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::createSoupMessageForHandleAndRequest):
+
 2012-10-09  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -687 +687 @@
 static bool createSoupMessageForHandleAndRequest(ResourceHandle* handle, const ResourceRequest& request)
 {
-    ResourceHandleInternal* d = handle->getInternal();
     ASSERT(handle);
+
+    ResourceHandleInternal* d = handle->getInternal();
     ASSERT(d->m_soupRequest);