Changeset 131373 in webkit

Timestamp:

Oct 15, 2012, 3:31:08 PM (13 years ago)

Author:

Simon Fraser

Message:

Ensure that GraphicsLayer positions are updated while doing threaded scrolling
​https://bugs.webkit.org/show_bug.cgi?id=99372

Reviewed by Anders Carlsson.

When doing threaded scrolling, the scrolling thread updates the positions of CALayers,
but doesn't update GraphicsLayers. This means that code that relies on GraphicsLayer positions
works incorrectly.

Threaded scrolling is not testabled in layout tests.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

• platform/graphics/GraphicsLayer.h:

(GraphicsLayer):
(WebCore::GraphicsLayer::syncPosition):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ScrollingCoordinator.cpp (modified) (1 diff)
• platform/graphics/GraphicsLayer.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Ensure that GraphicsLayer positions are updated while doing threaded scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=99372
+
+        Reviewed by Anders Carlsson.
+
+        When doing threaded scrolling, the scrolling thread updates the positions of CALayers,
+        but doesn't update GraphicsLayers. This means that code that relies on GraphicsLayer positions
+        works incorrectly.
+        
+        Threaded scrolling is not testabled in layout tests.
+
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
+        * platform/graphics/GraphicsLayer.h:
+        (GraphicsLayer):
+        (WebCore::GraphicsLayer::syncPosition):
+
 2012-10-15  Tommy Widenflycht  <tommyw@google.com>
 

trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -236 +236 @@
 
     frameView->setInProgrammaticScroll(oldProgrammaticScroll);
+
+    if (GraphicsLayer* scrollLayer = scrollLayerForFrameView(frameView))
+        scrollLayer->syncPosition(-frameView->scrollPosition());
 }
 

trunk/Source/WebCore/platform/graphics/GraphicsLayer.h

@@ -247 +247 @@
     const FloatPoint& position() const { return m_position; }
     virtual void setPosition(const FloatPoint& p) { m_position = p; }
+
+    // For platforms that move underlying platform layers on a different thread for scrolling; just update the GraphicsLayer state.
+    virtual void syncPosition(const FloatPoint& p) { m_position = p; }
     
     // Anchor point: (0, 0) is top left, (1, 1) is bottom right. The anchor point