Changeset 131471 in webkit

Timestamp:

Oct 16, 2012, 10:23:03 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Inspector should allow reading the compositing debug settings
​https://bugs.webkit.org/show_bug.cgi?id=99458

Patch by Antoine Quint <Antoine Quint> on 2012-10-16
Reviewed by Timothy Hatcher.

• inspector/Inspector.json:
• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCompositingBordersVisible):

• inspector/InspectorPageAgent.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/Inspector.json (modified) (1 diff)
• inspector/InspectorPageAgent.cpp (modified) (1 diff)
• inspector/InspectorPageAgent.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-10-16  Antoine Quint  <graouts@apple.com>
+
+        Inspector should allow reading the compositing debug settings
+        https://bugs.webkit.org/show_bug.cgi?id=99458
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/Inspector.json:
+        * inspector/InspectorPageAgent.cpp:
+        (WebCore::InspectorPageAgent::getCompositingBordersVisible):
+        * inspector/InspectorPageAgent.h:
+
 2012-10-16  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/inspector/Inspector.json

@@ -404 +404 @@
                 ],
                 "description": "Toggles mouse event-based touch event emulation.",
+                "hidden": true
+            },
+            {
+                "name": "getCompositingBordersVisible",
+                "description": "Indicates the visibility of compositing borders.",
+                "returns": [
+                    { "name": "result", "type": "boolean", "description": "If true, compositing borders are visible." }
+                ],
                 "hidden": true
             },

trunk/Source/WebCore/inspector/InspectorPageAgent.cpp

@@ -1109 +1109 @@
 }
 
+void InspectorPageAgent::getCompositingBordersVisible(ErrorString* error, bool* outParam)
+{
+    Settings* settings = m_page->settings();
+    if (!settings) {
+        *error = "Internal error: unable to read settings.";
+        return;
+    }
+
+    *outParam = settings->showDebugBorders() || settings->showRepaintCounter();
+}
+
 void InspectorPageAgent::setCompositingBordersVisible(ErrorString*, bool visible)
 {

trunk/Source/WebCore/inspector/InspectorPageAgent.h

@@ -119 +119 @@
     virtual void canOverrideDeviceOrientation(ErrorString*, bool*);
     virtual void setTouchEmulationEnabled(ErrorString*, bool);
+    virtual void getCompositingBordersVisible(ErrorString*, bool* out_param);
     virtual void setCompositingBordersVisible(ErrorString*, bool);