Changeset 132370 in webkit

Timestamp:

Oct 24, 2012, 10:44:06 AM (12 years ago)

Author:

jochen@chromium.org

Message:

[chromium] Use include paths relative to Source/ in the TestRunner's public API
​https://bugs.webkit.org/show_bug.cgi?id=100079

Reviewed by Adam Barth.

For a inside-chromium build, we usually don't add the WebKit API paths
as include paths, so including files by name only does not work.

Eventually we might want to move to a model where all includes are
relative to Source/, so we're using that here already now.

• DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
• DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
• DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (modified) (1 diff)
• DumpRenderTree/chromium/TestRunner/public/WebEventSender.h (modified) (1 diff)
• DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-10-24  Jochen Eisinger  <jochen@chromium.org>
+
+        [chromium] Use include paths relative to Source/ in the TestRunner's public API
+        https://bugs.webkit.org/show_bug.cgi?id=100079
+
+        Reviewed by Adam Barth.
+
+        For a inside-chromium build, we usually don't add the WebKit API paths
+        as include paths, so including files by name only does not work.
+
+        Eventually we might want to move to a model where all includes are
+        relative to Source/, so we're using that here already now.
+
+        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
+        * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
+        * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
+
 2012-10-24  Ojan Vafai  <ojan@chromium.org>
 

trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp

@@ -94 +94 @@
                 '../chromium/TestRunner/public',
                 '../chromium/TestRunner/src',
+                '../../../Source',
             ],
             'direct_dependent_settings': {
                 'include_dirs': [
                     '../chromium/TestRunner/public',
+                    '../../../Source',
                 ],
             },

trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h

@@ -32 +32 @@
 #define WebEventSender_h
 
-#include "WebDragOperation.h"
+#include "WebKit/chromium/public/WebDragOperation.h"
 
 namespace WebKit {

trunk/Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h

@@ -32 +32 @@
 #define WebTestDelegate_h
 
-#include "platform/WebString.h"
-#include "platform/WebVector.h"
+#include "Platform/chromium/public/WebString.h"
+#include "Platform/chromium/public/WebVector.h"
 
 namespace WebKit {